Skip to content

Fix a minor logging issue #483

@alexeyr-ci

Description

@alexeyr-ci

Using %O for errors in

log.error('Caught Error when creating context in buildVM, %O', error);

is worse than log.error(error, message). Not just editing it because this logs the error twice with different messages, first here and then in errorReporter.message.

  1. Consider adding alreadyLogged or label as parameters to errorReporter.message/error, they are probably useful for other calls as well.
  2. Add an ESLint rule banning %O, %o, and %j (all are the same) by default.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions