Skip to content

[WIP] Use the new generated_component_packs_loading_strategy config at react_on_rails #522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[WIP] Use the new generated_component_packs_loading_strategy config at react_on_rails #522

wants to merge 2 commits into from

Conversation

@AbanoubGhadban
Copy link
Contributor

@AbanoubGhadban AbanoubGhadban commented Mar 10, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Chores
    • Updated a front-end build tool dependency to version 8.1.0.
    • No user-facing changes; app behavior and interfaces remain unchanged.
    • Applies to development/test environment only; production features unaffected.
    • Build and packaging workflows continue to operate as before.
    • No action required from end-users.

@AbanoubGhadban
Update Gemfile and dependencies to use GitHub branches for react_on_r…
19e39c9 
…ails and shakapacker

- Switch react_on_rails and shakapacker to use specific GitHub branches
- Update Gemfile.development_dependencies to reference GitHub repositories
- Update Gemfile.lock and spec/dummy files to reflect new gem sources
- Bump shakapacker version to 8.1.0 in package.json and yarn.lock
- Remove deprecated configuration option in react_on_rails initializer
@AbanoubGhadban
Update selective hydration documentation for React on Rails
c950a9e
@coderabbitai
Copy link

coderabbitai bot commented Mar 10, 2025 •
edited
Loading

Walkthrough

Updates the shakapacker dependency version in spec/dummy/package.json from 8.0.0 to 8.1.0. No other files or settings are changed.

Changes

Cohort / File(s) Summary
Dependency Version Update
spec/dummy/package.json		 Bump shakapacker from 8.0.0 to 8.1.0

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

I twitch my whiskers, nod with delight,
A tiny bump—8.0 to 8.1—just right.
Carrots stacked, dependencies neat,
Package.json taps a steady beat.
Hop, commit, merge—so clean and sunny,
Shakapacker fresh—ship it, honey! 🥕✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Title Check ⚠️ Warning The pull request title refers to using a new generated_component_packs_loading_strategy config in react_on_rails and marks the work-in-progress, but the actual changes solely bump the shakapacker dependency version in spec/dummy/package.json without any related configuration or functionality updates. Change the pull request title to accurately reflect the bump of the shakapacker dependency in spec/dummy/package.json and remove the WIP prefix if the change is ready for review.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch abanoubghadban/pro521-add-support-for-async-scripts-in-the-view
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c950a9e and 5ad6ead.

⛔ Files ignored due to path filters (1)
  • spec/dummy/yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (1)
  • spec/dummy/package.json (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • spec/dummy/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: build-and-test

Comment @coderabbitai help to get the list of available commands and usage tips.

@AbanoubGhadban AbanoubGhadban changed the title Use the new generated_component_packs_loading_strategy config at react_on_rails [WIP] Use the new generated_component_packs_loading_strategy config at react_on_rails Mar 10, 2025
@ihabadham ihabadham force-pushed the abanoubghadban/pro521-add-support-for-async-scripts-in-the-view branch from c950a9e to 5ad6ead Compare September 25, 2025 14:55
@ihabadham ihabadham force-pushed the abanoubghadban/pro521-add-support-for-async-scripts-in-the-view branch from 30e63bc to c950a9e Compare September 25, 2025 15:26
@AbanoubGhadban
Copy link
Contributor Author

AbanoubGhadban commented Sep 26, 2025

Lets implement it later at react_on_rails repo after migrating shakapacker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexeyr-ci alexeyr-ci alexeyr-ci approved these changes

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

Assignees

@ihabadham ihabadham

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AbanoubGhadban @alexeyr-ci @ihabadham