Skip to content

Commit 7973309

Browse files
author
Alex Fedoseev
authored
Merge pull request #31 from dfalling/switch_to_rescript_webapi
Switch from bs-webapi to rescript-webapi
2 parents 6f7e14e + ee8fb79 commit 7973309

9 files changed

+56
-53
lines changed

bsconfig.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
],
1414
"bs-dependencies": [
1515
"@rescript/react",
16-
"bs-webapi",
16+
"rescript-webapi",
1717
"rescript-logger"
1818
],
1919
"bs-dev-dependencies": [

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,10 +46,10 @@
4646
},
4747
"peerDependencies": {
4848
"@rescript/react": ">=0.10.3",
49-
"bs-webapi": ">=0.15.9"
49+
"rescript-webapi": ">=0.6.0"
5050
},
5151
"devDependencies": {
52-
"@rescript/react": "0.10.3",
52+
"@rescript/react": ">=0.10.3",
5353
"autoprefixer": "9.8.6",
5454
"bs-webapi": "0.19.1",
5555
"bsb-js": "1.1.7",

src/Dnd__DndManager.res

Lines changed: 21 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -794,7 +794,7 @@ module Make = (Context: Context.T) => {
794794
let scrollPosition = Scrollable.Window.getScrollPosition()
795795

796796
let rect = item.element->HtmlElement.getBoundingClientRect
797-
let style = window->Window.getComputedStyle(item.element->Web.htmlElementToElement, _)
797+
let style = window->Window.getComputedStyle(item.element->Web.htmlElementToElement)
798798

799799
let viewportRect = rect->Geometry.getViewportRect
800800
let pageRect = viewportRect->Geometry.getPageRectFromViewportRect(scrollPosition)
@@ -843,22 +843,22 @@ module Make = (Context: Context.T) => {
843843
"MouseSubscriptions::SubscriptionsInstalled"
844844
("ItemId", itemId)
845845
)
846-
Window.addMouseMoveEventListener(onMouseMove, window)
847-
Window.addMouseUpEventListener(onMouseUp, window)
848-
HtmlElement.addKeyDownEventListener(onKeyDown, ghost.element)
849-
Window.addEventListener("resize", onResize, window)
850-
Window.addEventListener("visibilitychange", onVisibilityChange, window)
846+
Window.addMouseMoveEventListener(window, onMouseMove)
847+
Window.addMouseUpEventListener(window, onMouseUp)
848+
HtmlElement.addKeyDownEventListener(ghost.element, onKeyDown)
849+
Window.addEventListener(window, "resize", onResize)
850+
Window.addEventListener(window, "visibilitychange", onVisibilityChange)
851851
},
852852
drop: () => {
853853
%log.debug(
854854
"MouseSubscriptions::SubscriptionsDropped"
855855
("ItemId", itemId)
856856
)
857-
Window.removeMouseMoveEventListener(onMouseMove, window)
858-
Window.removeMouseUpEventListener(onMouseUp, window)
859-
HtmlElement.removeKeyDownEventListener(onKeyDown, ghost.element)
860-
Window.removeEventListener("resize", onResize, window)
861-
Window.removeEventListener("visibilitychange", onVisibilityChange, window)
857+
Window.removeMouseMoveEventListener(window, onMouseMove)
858+
Window.removeMouseUpEventListener(window, onMouseUp)
859+
HtmlElement.removeKeyDownEventListener(ghost.element, onKeyDown)
860+
Window.removeEventListener(window, "resize", onResize)
861+
Window.removeEventListener(window, "visibilitychange", onVisibilityChange)
862862
},
863863
}
864864
| #Touch =>
@@ -875,22 +875,22 @@ module Make = (Context: Context.T) => {
875875
"TouchSubscriptions::SubscriptionsInstalled"
876876
("ItemId", itemId)
877877
)
878-
Window.addEventListener("touchmove", onTouchMove, window)
879-
Window.addEventListener("touchend", onTouchEnd, window)
880-
Window.addEventListener("contextmenu", onContextMenu, window)
881-
Window.addEventListener("orientationchange", onOrientationChange, window)
882-
Window.addEventListener("visibilitychange", onVisibilityChange, window)
878+
Window.addEventListener(window, "touchmove", onTouchMove)
879+
Window.addEventListener(window, "touchend", onTouchEnd)
880+
Window.addEventListener(window, "contextmenu", onContextMenu)
881+
Window.addEventListener(window, "orientationchange", onOrientationChange)
882+
Window.addEventListener(window, "visibilitychange", onVisibilityChange)
883883
},
884884
drop: () => {
885885
%log.debug(
886886
"TouchSubscriptions::SubscriptionsDropped"
887887
("ItemId", itemId)
888888
)
889-
Window.removeEventListener("touchmove", onTouchMove, window)
890-
Window.removeEventListener("touchend", onTouchEnd, window)
891-
Window.removeEventListener("contextmenu", onContextMenu, window)
892-
Window.removeEventListener("orientationchange", onOrientationChange, window)
893-
Window.removeEventListener("visibilitychange", onVisibilityChange, window)
889+
Window.removeEventListener(window, "touchmove", onTouchMove)
890+
Window.removeEventListener(window, "touchend", onTouchEnd)
891+
Window.removeEventListener(window, "contextmenu", onContextMenu)
892+
Window.removeEventListener(window, "orientationchange", onOrientationChange)
893+
Window.removeEventListener(window, "visibilitychange", onVisibilityChange)
894894
},
895895
}
896896
}

src/Dnd__DraggableItem.res

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,10 @@ module Make = (Context: Context.T) => {
1414
module Helpers = {
1515
let clearSelection = () => {
1616
open Webapi.Dom
17-
window->Window.getSelection->Selection.removeAllRanges
17+
switch window->Window.getSelection {
18+
| Some(selection) => Selection.removeAllRanges(selection)
19+
| None => ()
20+
}
1821
}
1922

2023
let getGeometry = element =>

src/Dnd__Events.res

Lines changed: 22 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -5,59 +5,59 @@ let addOptions = {"passive": false, "once": false, "capture": false}
55
let removeOptions = {"passive": false, "capture": false}
66

77
let subscribeToMouseMove = handler =>
8-
Window.addMouseMoveEventListenerWithOptions(handler, addOptions, window)
8+
Window.addMouseMoveEventListenerWithOptions(window, handler, addOptions)
99
let unsubscribeFromMouseMove = handler =>
10-
Window.removeMouseMoveEventListenerWithOptions(handler, removeOptions, window)
10+
Window.removeMouseMoveEventListenerWithOptions(window, handler, removeOptions)
1111

1212
let subscribeToMouseUp = handler =>
13-
Window.addMouseUpEventListenerWithOptions(handler, addOptions, window)
13+
Window.addMouseUpEventListenerWithOptions(window, handler, addOptions)
1414
let unsubscribeFromMouseUp = handler =>
15-
Window.removeMouseUpEventListenerWithOptions(handler, removeOptions, window)
15+
Window.removeMouseUpEventListenerWithOptions(window, handler, removeOptions)
1616

1717
let subscribeToDrag = handler =>
18-
Window.addEventListenerWithOptions("drag", handler, addOptions, window)
18+
Window.addEventListenerWithOptions(window, "drag", handler, addOptions)
1919
let unsubscribeFromDrag = handler =>
20-
Window.removeEventListenerWithOptions("drag", handler, removeOptions, window)
20+
Window.removeEventListenerWithOptions(window, "drag", handler, removeOptions)
2121

2222
let subscribeToResize = handler =>
23-
Window.addEventListenerWithOptions("resize", handler, addOptions, window)
23+
Window.addEventListenerWithOptions(window, "resize", handler, addOptions)
2424
let unsubscribeFromResize = handler =>
25-
Window.removeEventListenerWithOptions("resize", handler, removeOptions, window)
25+
Window.removeEventListenerWithOptions(window, "resize", handler, removeOptions)
2626

2727
let subscribeToKeyUp = handler =>
28-
Window.addKeyUpEventListenerWithOptions(handler, addOptions, window)
28+
Window.addKeyUpEventListenerWithOptions(window, handler, addOptions)
2929
let unsubscribeFromKeyUp = handler =>
30-
Window.removeKeyUpEventListenerWithOptions(handler, removeOptions, window)
30+
Window.removeKeyUpEventListenerWithOptions(window, handler, removeOptions)
3131

3232
let subscribeToKeyDown = handler =>
33-
Window.addKeyDownEventListenerWithOptions(handler, addOptions, window)
33+
Window.addKeyDownEventListenerWithOptions(window, handler, addOptions)
3434
let unsubscribeFromKeyDown = handler =>
35-
Window.removeKeyDownEventListenerWithOptions(handler, removeOptions, window)
35+
Window.removeKeyDownEventListenerWithOptions(window, handler, removeOptions)
3636

3737
let subscribeToTouchMove = handler =>
38-
Window.addEventListenerWithOptions("touchmove", handler, addOptions, window)
38+
Window.addEventListenerWithOptions(window, "touchmove", handler, addOptions)
3939
let unsubscribeFromTouchMove = handler =>
40-
Window.removeEventListenerWithOptions("touchmove", handler, removeOptions, window)
40+
Window.removeEventListenerWithOptions(window, "touchmove", handler, removeOptions)
4141

4242
let subscribeToTouchEnd = handler =>
43-
Window.addEventListenerWithOptions("touchend", handler, addOptions, window)
43+
Window.addEventListenerWithOptions(window, "touchend", handler, addOptions)
4444
let unsubscribeFromTouchEnd = handler =>
45-
Window.removeEventListenerWithOptions("touchend", handler, removeOptions, window)
45+
Window.removeEventListenerWithOptions(window, "touchend", handler, removeOptions)
4646

4747
let subscribeToOrientationChange = handler =>
48-
Window.addEventListenerWithOptions("orientationchange", handler, addOptions, window)
48+
Window.addEventListenerWithOptions(window, "orientationchange", handler, addOptions)
4949
let unsubscribeFromOrientationChange = handler =>
50-
Window.removeEventListenerWithOptions("orientationchange", handler, removeOptions, window)
50+
Window.removeEventListenerWithOptions(window, "orientationchange", handler, removeOptions)
5151

5252
let subscribeToContextMenu = handler =>
53-
Window.addEventListenerWithOptions("contextmenu", handler, addOptions, window)
53+
Window.addEventListenerWithOptions(window, "contextmenu", handler, addOptions)
5454
let unsubscribeFromContextMenu = handler =>
55-
Window.removeEventListenerWithOptions("contextmenu", handler, removeOptions, window)
55+
Window.removeEventListenerWithOptions(window, "contextmenu", handler, removeOptions)
5656

5757
let subscribeToVisibilityChange = handler =>
58-
Window.addEventListenerWithOptions("visibilitychange", handler, addOptions, window)
58+
Window.addEventListenerWithOptions(window, "visibilitychange", handler, addOptions)
5959
let unsubscribeFromVisibilityChange = handler =>
60-
Window.removeEventListenerWithOptions("visibilitychange", handler, removeOptions, window)
60+
Window.removeEventListenerWithOptions(window, "visibilitychange", handler, removeOptions)
6161

6262
module Mouse = {
6363
let leftClick = event => event->ReactEvent.Mouse.button === 0

src/Dnd__Geometry.res

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ let getGeometry = (rect, style, scroll) => {
9999
let getElementGeometry = (el: Dom.htmlElement) =>
100100
getGeometry(
101101
el->HtmlElement.getBoundingClientRect,
102-
window->Window.getComputedStyle(el->Web.htmlElementToElement, _),
102+
window->Window.getComputedStyle(el->Web.htmlElementToElement),
103103
)
104104

105105
let getViewport = () => {

src/Dnd__Scrollable.res

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ module Element = {
7575
element
7676
->Webapi.Dom.HtmlElement.parentElement
7777
->Option.flatMap(element => {
78-
let style = Webapi.Dom.window->Webapi.Dom.Window.getComputedStyle(element, _)
78+
let style = Webapi.Dom.window->Webapi.Dom.Window.getComputedStyle(element)
7979
if style->isScrollable {
8080
let element = {
8181
open Webapi.Dom

src/Dnd__Scroller.res

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ let windowScroller = (
145145
Webapi.requestCancellableAnimationFrame(_ => {
146146
{
147147
open Webapi.Dom
148-
window->Window.scrollBy(x, y, _)
148+
window->Window.scrollBy(x, y)
149149
}
150150

151151
onScroll()
@@ -157,7 +157,7 @@ let windowScroller = (
157157
Webapi.requestCancellableAnimationFrame(_ => {
158158
{
159159
open Webapi.Dom
160-
window->Window.scrollBy(x, 0., _)
160+
window->Window.scrollBy(x, 0.)
161161
}
162162

163163
onScroll()
@@ -169,7 +169,7 @@ let windowScroller = (
169169
Webapi.requestCancellableAnimationFrame(_ => {
170170
{
171171
open Webapi.Dom
172-
window->Window.scrollBy(0., y, _)
172+
window->Window.scrollBy(0., y)
173173
}
174174

175175
onScroll()

src/Dnd__Style.res

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,5 +15,5 @@ let translate = (x, y) => "translate(" ++ (x->px ++ (", " ++ (y->px ++ ")")))
1515

1616
let getComputedStyle = element => {
1717
open Webapi.Dom
18-
window->Window.getComputedStyle(element->Web.htmlElementToElement, _)
18+
window->Window.getComputedStyle(element->Web.htmlElementToElement)
1919
}

0 commit comments

Comments
 (0)