Skip to content

Don't update Bundler in generator specs #539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
justin808 merged 2 commits into from
Jan 7, 2025
+4 −2
Merged

Don't update Bundler in generator specs #539

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc258ff
TEST: Don't update Bundler in generator specs
tomdracz Jan 6, 2025
6aa06a5
Try use latest rubygems
tomdracz Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/dummy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ jobs:
- uses: ruby/setup-ruby@v1
with:
ruby-version: '3.1.2'
rubygems: latest
Copy link

@coderabbitai coderabbitai bot Jan 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Consider updating Ruby version in dummy.yml workflow

The workflow uses Ruby 3.1.2 while other workflows (ruby.yml, generator.yml) test against multiple versions up to 3.3. Consider:

  • Aligning with other workflows by using the matrix strategy
  • Or at minimum, updating to Ruby 3.3 to match the latest tested version
🔗 Analysis chain

LGTM! Consider aligning Ruby versions across workflows.

The addition of rubygems: latest is consistent with the changes in other workflows. However, this workflow uses Ruby 3.1.2 while others use version ranges including 3.3.

Let's verify Ruby version usage across workflows:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check Ruby version specifications across workflow files
echo "Ruby version specifications in workflows:"
rg "ruby-version:" .github/workflows/

Length of output: 392

Script:

#!/bin/bash
# Check matrix Ruby version configurations
echo "Matrix configurations in workflows:"
rg "matrix:" -A 5 .github/workflows/

Length of output: 1134

- name: Install dependencies
run: |
bundle install
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/generator.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,5 +52,6 @@ jobs:
- uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ matrix.ruby }}
rubygems: latest
bundler-cache: true
- run: bundle exec rake run_spec:generator
2 changes: 2 additions & 0 deletions .github/workflows/ruby.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ jobs:
- uses: ruby/setup-ruby@v1
with:
ruby-version: '3.3'
rubygems: latest
bundler-cache: true

- name: Ruby rubocop
Expand Down Expand Up @@ -69,6 +70,7 @@ jobs:
- uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ matrix.ruby }}
rubygems: latest
bundler-cache: true

- name: Ruby specs
Expand Down
2 changes: 0 additions & 2 deletions spec/generator_specs/generator_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,12 @@
# Issue resolved in Capybara v3.40.0, but Ruby 2.7 support dropped; last compatible version is v3.39.2.
# Ref: https://github.com/shakacode/shakapacker/issues/498
sh_in_dir({}, BASE_RAILS_APP_PATH, %(
gem update bundler
echo 'gem "shakapacker", :path => "#{GEM_ROOT}"' >> Gemfile
echo 'gem "rack", "< 3.0.0"' >> Gemfile
bundle install
))
else
sh_in_dir({}, BASE_RAILS_APP_PATH, %(
gem update bundler
bundle add shakapacker --path "#{GEM_ROOT}"
))
end
Expand Down
Loading