Merge pull request #207 from shapeblue/suse-15-6-compat

OpenSUSE 15.6 compatibility changes

Author: vishesh92

Ansible/roles/cloudmonkey/tasks/suse.yml

@@ -15,9 +15,7 @@
 #limitations under the License.
 
 - name: install jq
-  zypper:
-   name: jq
-   state: latest
+  shell: "zypper install -y jq"
 
 - name: ensure cm config is removed
   file: path=/root/.cloudmonkey/config state=absent

Ansible/roles/cloudstack-manager/tasks/suse-acs.yml

@@ -18,16 +18,10 @@
   template: src=cloudstack.repo.j2 dest=/etc/zypp/repos.d/cloudstack.repo
 
 - name: Ensure CloudStack packages are installed
-  zypper:
-    name:
-      - "{{ cloudstack_management_package }}*"
-      - "{{ cloudstack_common_package }}*"
-    state: present
+  shell: "zypper install -y {{ cloudstack_management_package }}* {{ cloudstack_common_package }}*"
 
 - name: Ensure MySQL Client is present
-  zypper:
-    name: mysql
-    state: present
+  shell: "zypper install -y mysql"
 
 - name: Fix messed up python mysql ssl libs
   copy:
@@ -47,7 +41,7 @@
   get_url: url="{{ vhdutil_url }}" dest=/usr/share/cloudstack-common/scripts/vm/hypervisor/xenserver/vhd-util mode=0755
 
 - name: Ensure CloudStack Usage Service is installed
-  zypper: name="{{ cloudstack_usage_package }}*" state=present
+  shell: "zypper install -y {{ cloudstack_usage_package }}*"
 
 - include: ./setupdb.yml
 

Ansible/roles/cloudstack-manager/tasks/suse.yml

@@ -18,9 +18,7 @@
     msg: "SUSE Specific Management Server Build"
 
 - name: Ensure selinux python bindings are installed (Ansible requirement)
-  zypper:
-    name: python3-selinux
-    state: present
+  shell: "zypper install -y python3-selinux"
   ignore_errors: yes
 
 - name: Set selinux to permissive
@@ -51,19 +49,19 @@
   when: use_firewalld|bool == False
 
 - name: Ensure CA Certs are latest
-  zypper: name=ca-certificates state=latest
+  shell: "zypper install -y ca-certificates"
 
 - name: install rng-tools to get entropy
-  zypper: name=haveged state=present
+  shell: "zypper install -y haveged"
 
 - name: determine number of db hosts
   set_fact: num_xen_hosts="{{ groups['xenserver_hosts'] | length }}"
 
 - name: update lvm2 as fix for bugzilla.redhat.com/show_bug.cgi?id=1294128
-  zypper: name=lvm2 state=latest
+  shell: "zypper install -y lvm2"
 
 - name: install qemu-tools
-  zypper: name=qemu-tools state=present
+  shell: "zypper install -y qemu-tools"
 
 - debug: msg="Set Java on VM"
 - set_fact: java_ver="{{ mgmt_java_ver }}"
@@ -79,9 +77,7 @@
 # Don't really need suse support for ccp
 
 - name: ensure rpcbind in installed
-  zypper:
-    name: rpcbind
-    state: present
+  shell: "zypper install -y rpcbind"
 
 - name: ensure rpcbind in started
   service:
@@ -93,7 +89,7 @@
   when: (num_marv_hosts > 0)
 
 - name: Ensure sshpass is installed
-  zypper: name=sshpass state=present
+  shell: "zypper install -y sshpass"
   when: (num_marv_hosts > 0)
 
 - name: Open 8096 when Marvin is required

Ansible/roles/kvm/tasks/kvm_networking_ovs_suse.yml

@@ -21,10 +21,7 @@
   template: src=bridge-blacklist.j2 dest="/etc/modprobe.d/bridge-blacklist.conf"
 
 - name: Install OVS
-  zypper: name={{ item }} state=present
-  with_items:
-    - openvswitch
-    - openvswitch-switch
+  shell: "zypper install -y openvswitch openvswitch-switch"
 
 - name: Start OVS
   systemd:

Ansible/roles/kvm/tasks/suse-acs.yml

@@ -25,12 +25,7 @@
     - kvm-agent
 
 - name: Ensure CloudStack packages are installed
-  zypper:
-    name:
-      - "{{ cloudstack_agent_package }}*"
-      - "{{ cloudstack_common_package }}*"
-    state: present
-    update_cache: yes
+  shell: "zypper install -y {{ cloudstack_agent_package }}* {{ cloudstack_common_package }}*"
   tags:
     - kvm
     - kvm-agent

Ansible/roles/kvm/tasks/suse.yml

@@ -18,13 +18,18 @@
     msg: "SUSE Specific KVM host Build"
 
 - name: Ensure selinux python bindings are installed (Ansible requirement)
-  zypper:
-    name: python3-selinux
-    state: present
+  shell: "zypper install -y python3-selinux"
   tags:
     - kvm
   ignore_errors: yes
 
+- name: install net-tools
+  shell: "zypper install -y net-tools"
+
+- name: install net-tools
+  shell: "zypper install -y net-tools-deprecated"
+  ignore_errors: yes # This package is deprecated. ignoring errors for older distros
+
 - name: Set selinux to permissive
   command: setenforce permissive
   changed_when: false
@@ -38,7 +43,7 @@
     - kvm
   ignore_errors: yes
 
-- include: ./kvm_networking_bridge_suse.yml
+- include: ./kvm_networking_bridge8.yml
   when: (not use_phys_hosts) and (kvm_network_mode == "bridge")
 
 - include: ./kvm_networking_ovs_suse.yml
@@ -55,19 +60,7 @@
 # Don't really need suse for phy hosts
 
 - name: Install basic utilities and tools - all versions
-  zypper: name={{ item }} state=present update_cache=yes
-  with_items:
-    - bind-utils
-    - openssh
-    - pciutils
-    - telnet
-    - tcpdump
-    - traceroute
-    - nano
-    - iftop
-    - rpcbind
-    - parted
-    - vim
+  shell: "zypper install -y bind-utils openssh pciutils telnet tcpdump traceroute nano iftop rpcbind parted vim"
   tags:
     - kvm
 
@@ -125,20 +118,35 @@
     - kvm-agent
 
 - name: Update /etc/sysconfig/libvirtd - LIBVIRTD_ARGS
-  lineinfile: dest=/etc/sysconfig/libvirtd regexp='LIBVIRTD_ARGS' line='LIBVIRTD_ARGS="--listen"' state=present
+  lineinfile: dest=/etc/sysconfig/libvirtd regexp='LIBVIRTD_ARGS' line='LIBVIRTD_ARGS="--listen"' state=present create=yes
   tags:
     - kvm
     - kvm-agent
 
-- name: Mask libvirtd sockets
-  shell: systemctl mask libvirtd.socket libvirtd-ro.socket libvirtd-admin.socket libvirtd-tls.socket libvirtd-tcp.socket
+- name: Reload systemd daemon after libvirtd service modification
+  command: systemctl daemon-reload
+  tags:
+    - kvm
+    - kvm-agent
 
 - name: Update /etc/libvirt/qemu.conf
   lineinfile: dest=/etc/libvirt/qemu.conf regexp='vnc_listen' line='vnc_listen = "0.0.0.0"' state=present
   tags:
     - kvm
     - kvm-agent
 
+- name: Mask libvirtd sockets
+  shell: systemctl mask libvirtd.socket libvirtd-ro.socket libvirtd-admin.socket libvirtd-tls.socket libvirtd-tcp.socket
+
+- name: Mask virtqemu sockets
+  shell: systemctl mask virtqemud.socket virtqemud-ro.socket virtqemud-admin.socket virtqemud virtnetworkd virtstoraged
+
+- name: Enable libvirtd service on reboot
+  shell: systemctl enable --now libvirtd
+  tags:
+    - kvm
+    - kvm-agent
+
 - name: Add iptables rules
   shell: "iptables -I INPUT -p tcp -m tcp --dport {{ item }} -j ACCEPT"
   with_items:

Ansible/roles/mysql/tasks/suse.yml

@@ -34,19 +34,13 @@
     - mysqlconf
 
 - name: Ensure selinux and mysql python bindings are installed (Ansible requirement)
-  zypper:
-    name:
-       - python3-PyMySQL
-       - python3-selinux
-    state: present
+  shell: "zypper install -y python3-PyMySQL python3-mysql-connector-python"
   tags:
     - mysql
     - mysqlconf
 
 - name: Ensure selinux python bindings are installed (Ansible requirement)
-  zypper:
-    name: python3-selinux
-    state: present
+  shell: "zypper install -y python3-selinux"
   tags:
     - mysql
     - mysqlconf
@@ -66,11 +60,16 @@
     - kvm
   ignore_errors: yes
 
+- name: Check if mysql server is installed
+  shell: rpm -q mysql-server
+  register: mysql_check
+  failed_when: false
+  changed_when: false
+
 - name: Ensure mysql server is installed
-  zypper:
-    name: mysql-server
-    state: present
+  shell: "zypper install -y mysql-server"
   register: mysqlinstalled
+  when: mysql_check.rc != 0
   tags:
     - mysql
     - mysqlconf

Ansible/roles/timezone/tasks/suse.yml

@@ -18,10 +18,7 @@
   command: "timedatectl set-timezone {{ env_timezone }}"
 
 - name: Install chrony
-  zypper:
-    name: chrony
-    state: present
-    update_cache: yes
+  shell: zypper install -y chrony
 
 - name: Start chrony SUSE
   service: