feat(chart): Split priorityClassName for controller and node daemonset

BREAKING CHANGE: Move priorityClassName from a top-level value to a controller/node specific value, so the controller can be system-cluster-critical and the node ds system-node-critical

Author: hrak

charts/cloudstack-csi/templates/csi-controller-deploy.yaml

@@ -208,8 +208,8 @@ spec:
       hostAliases:
         {{- toYaml . | nindent 8 }}
       {{- end }}
-    {{- if .Values.priorityClassName }}
-      priorityClassName: {{ .Values.priorityClassName }}
+    {{- if .Values.controller.priorityClassName }}
+      priorityClassName: {{ .Values.controller.priorityClassName }}
     {{- end }}
     {{- with .Values.imagePullSecrets }}
       imagePullSecrets:

charts/cloudstack-csi/templates/csi-node-ds.yaml

@@ -174,8 +174,8 @@ spec:
       hostAliases:
         {{- toYaml . | nindent 8 }}
       {{- end }}
-    {{- if .Values.priorityClassName }}
-      priorityClassName: {{ .Values.priorityClassName }}
+    {{- if .Values.node.priorityClassName }}
+      priorityClassName: {{ .Values.node.priorityClassName }}
     {{- end }}
     {{- with .Values.imagePullSecrets }}
       imagePullSecrets:

charts/cloudstack-csi/values.yaml

@@ -66,6 +66,7 @@ controller:
       # maxSurge is the maximum number of pods that can be
       # created over the desired number of pods.
       maxSurge: 1
+  priorityClassName: ""
   podSecurityContext:
     runAsNonRoot: true
     runAsUser: 65532
@@ -118,7 +119,7 @@ node:
       hostPath:
         path: /etc/cacert
   dnsPolicy: ClusterFirstWithHostNet
-    
+  priorityClassName: ""
   podSecurityContext: {}
 
   securityContext: {}
@@ -208,8 +209,6 @@ secret:
       secret-key: ""
   hostMount: false
 
-priorityClassName: ""
-
 imagePullSecrets: []
 # - name: my-imagepull-secret
 

deploy/k8s/node-daemonset.yaml

@@ -26,7 +26,7 @@ spec:
 
       containers:
         - name: cloudstack-csi-node
-          image: ghcr.io/leaseweb/cloudstack-csi-driver:master
+          image: cloudstack-csi-driver
           imagePullPolicy: Always
           args:
             - "-endpoint=$(CSI_ENDPOINT)"
@@ -56,6 +56,8 @@ spec:
               mountPropagation: Bidirectional
             - name: device-dir
               mountPath: /dev
+            - name: cloud-init-dir
+              mountPath: /run/cloud-init/
             - name: cloudstack-conf
               mountPath: /etc/cloudstack-csi-driver
           ports:
@@ -131,6 +133,10 @@ spec:
           hostPath:
             path: /var/lib/kubelet/plugins_registry
             type: Directory
+        - name: cloud-init-dir
+          hostPath:
+            path: /run/cloud-init/
+            type: Directory
         - name: cloudstack-conf
           secret:
             secretName: cloudstack-secret