change rule_id -> rule_number and add doc

Author: sudo87

cloudstack/resource_cloudstack_network_acl_rule.go

@@ -57,7 +57,7 @@ func resourceCloudStackNetworkACLRule() *schema.Resource {
 				Optional: true,
 				Elem: &schema.Resource{
 					Schema: map[string]*schema.Schema{
-						"rule_id": {
+						"rule_number": {
 							Type:     schema.TypeInt,
 							Optional: true,
 							Computed: true,
@@ -210,7 +210,7 @@ func createNetworkACLRule(d *schema.ResourceData, meta interface{}, rule map[str
 	p := cs.NetworkACL.NewCreateNetworkACLParams(rule["protocol"].(string))
 
 	// If a rule ID is specified, set it
-	if ruleId, ok := rule["rule_id"].(int); ok && ruleId > 0 {
+	if ruleId, ok := rule["rule_number"].(int); ok && ruleId > 0 {
 		p.SetNumber(ruleId)
 	}
 
@@ -644,12 +644,12 @@ func verifyNetworkACLParams(d *schema.ResourceData) error {
 }
 
 func verifyNetworkACLRuleParams(d *schema.ResourceData, rule map[string]interface{}) error {
-	if ruleId, ok := rule["rule_id"]; ok && ruleId != nil {
-		if rId, ok := ruleId.(int); ok && rId != 0 {
-			// Validate only if rule_id is explicitly set (non-zero)
+	if ruleNum, ok := rule["rule_number"]; ok && ruleNum != nil {
+		if rId, ok := ruleNum.(int); ok && rId != 0 {
+			// Validate only if rule_number is explicitly set (non-zero)
 			if rId < 1 || rId > 65535 {
 				return fmt.Errorf(
-					"%q must be between %d and %d inclusive, got: %d", "rule_id", 1, 65535, rId)
+					"%q must be between %d and %d inclusive, got: %d", "rule_number", 1, 65535, rId)
 			}
 		}
 	}

website/docs/r/network_acl_rule.html.markdown

@@ -48,6 +48,8 @@ The following arguments are supported:
 
 The `rule` block supports:
 
+* `rule_number` - (Optional) The number of the ACL item, its ordering.
+
 * `action` - (Optional) The action for the rule. Valid options are: `allow` and
     `deny` (defaults allow).
 
@@ -68,6 +70,8 @@ The `rule` block supports:
 * `traffic_type` - (Optional) The traffic type for the rule. Valid options are:
     `ingress` or `egress` (defaults ingress).
 
+* `description` - (Optional) A description indicating why the ACL rule is required.
+
 ## Attributes Reference
 
 The following attributes are exported: