allocator: in case of null guest OS don't fail prioritisation completely (apache#3607)

In case of null guest OS found for a template, don't fail prioritisation
completely (could still work based on HVM etc).

Signed-off-by: Rohit Yadav <[email protected]>

Author: rohityadavcloud

server/src/main/java/com/cloud/agent/manager/allocator/impl/FirstFitAllocator.java

@@ -29,8 +29,6 @@
 import org.apache.log4j.Logger;
 import org.springframework.stereotype.Component;
 
-import com.google.common.base.Strings;
-
 import com.cloud.agent.manager.allocator.HostAllocator;
 import com.cloud.capacity.CapacityManager;
 import com.cloud.capacity.CapacityVO;
@@ -419,10 +417,6 @@ protected List<? extends Host> prioritizeHosts(VMTemplateVO template, ServiceOff
         // Determine the guest OS category of the template
         String templateGuestOSCategory = getTemplateGuestOSCategory(template);
 
-        if (Strings.isNullOrEmpty(templateGuestOSCategory)) {
-            return hosts;
-        }
-
         List<Host> prioritizedHosts = new ArrayList<Host>();
         List<Host> noHvmHosts = new ArrayList<Host>();
 
@@ -453,7 +447,7 @@ protected List<? extends Host> prioritizeHosts(VMTemplateVO template, ServiceOff
             String hostGuestOSCategory = getHostGuestOSCategory(host);
             if (hostGuestOSCategory == null) {
                 continue;
-            } else if (templateGuestOSCategory.equals(hostGuestOSCategory)) {
+            } else if (templateGuestOSCategory != null && templateGuestOSCategory.equals(hostGuestOSCategory)) {
                 highPriorityHosts.add(host);
             } else {
                 lowPriorityHosts.add(host);