upgrade to phpstan v2

Author: nicklog

composer.json

@@ -63,12 +63,12 @@
         "doctrine/coding-standard": "^12.0",
         "roave/security-advisories": "dev-latest",
         "squizlabs/php_codesniffer": "^3.11",
-        "phpstan/phpstan": "^1.12",
-        "phpstan/phpstan-deprecation-rules": "^1.2",
-        "phpstan/phpstan-phpunit": "^1.4",
-        "phpstan/phpstan-strict-rules": "^1.6",
-        "phpstan/phpstan-symfony": "^1.4",
-        "phpstan/phpstan-doctrine": "^1.5",
+        "phpstan/phpstan": "^2.1",
+        "phpstan/phpstan-deprecation-rules": "^2.0",
+        "phpstan/phpstan-phpunit": "^2.0",
+        "phpstan/phpstan-strict-rules": "^2.0",
+        "phpstan/phpstan-symfony": "^2.0",
+        "phpstan/phpstan-doctrine": "^2.0",
         "phpunit/phpunit": "^11.5",
         "symfony/var-dumper": "^7.2",
         "symfony/clock": "^7.2"

src/DependencyInjection/Compiler/CronJobCompilerPass.php

@@ -10,6 +10,8 @@
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\DependencyInjection\Reference;
 
+use function is_array;
+
 final class CronJobCompilerPass implements CompilerPassInterface
 {
     public const CRON_JOB_TAG_ID = 'shapecode_cron.cron_job';
@@ -22,6 +24,10 @@ public function process(ContainerBuilder $container): void
 
         foreach ($tagged as $id => $configs) {
             foreach ($configs as $config) {
+                if (! is_array($config)) {
+                    throw new RuntimeException('config must be an array', 1740941125172);
+                }
+
                 if (! isset($config['expression'])) {
                     throw new RuntimeException('missing expression config', 1653426737628);
                 }

tests/Command/CronRunCommandTest.php

@@ -73,7 +73,7 @@ public function testRun(): void
 
         $this->command->run($this->input, $this->output);
 
-        self::assertEquals('shapecode:cron:run', $this->command->getName());
+        self::assertSame('shapecode:cron:run', $this->command->getName());
     }
 
     public function testRunWithTimeout(): void
@@ -95,6 +95,6 @@ public function testRunWithTimeout(): void
 
         $this->command->run($this->input, $this->output);
 
-        self::assertEquals('shapecode:cron:run', $this->command->getName());
+        self::assertSame('shapecode:cron:run', $this->command->getName());
     }
 }

tests/CronJob/CronJobManagerTest.php

@@ -40,14 +40,14 @@ static function (LoadJobsEvent $event) use ($expression, $command): LoadJobsEven
         $jobs = $cronJobManager->getJobs();
 
         self::assertCount(1, $jobs);
-        self::assertEquals($commandName, $jobs->first()->command);
-        self::assertEquals($expression, $jobs->first()->expression);
+        self::assertSame($commandName, $jobs->first()->command);
+        self::assertSame($expression, $jobs->first()->expression);
 
         // Run second time to assert the same result.
         $jobs = $cronJobManager->getJobs();
 
         self::assertCount(1, $jobs);
-        self::assertEquals($commandName, $jobs->first()->command);
-        self::assertEquals($expression, $jobs->first()->expression);
+        self::assertSame($commandName, $jobs->first()->command);
+        self::assertSame($expression, $jobs->first()->expression);
     }
 }