Merge pull request #564 from shapehq/enhancement/getDefaultSpecification

Introduce getDefaultSpecification for #558

Author: ulrikandersen

src/features/projects/data/useProjectSelection.ts

@@ -4,7 +4,13 @@ import NProgress from "nprogress"
 import { useRouter, usePathname } from "next/navigation"
 import { useContext } from "react"
 import { ProjectsContext } from "@/common"
-import { Project, ProjectNavigator, getProjectSelectionFromPath } from "../domain"
+import {
+  Project,
+  ProjectNavigator,
+  getProjectSelectionFromPath,
+  getDefaultSpecification
+  
+} from "../domain"
 
 export default function useProjectSelection() {
   const router = useRouter()
@@ -29,7 +35,7 @@ export default function useProjectSelection() {
     },
     selectProject: (project: Project) => {
       const version = project.versions[0]
-      const specification = version.specifications.find(spec => spec.isDefault) || version.specifications[0]
+      const specification = getDefaultSpecification(version)
       NProgress.start()
       projectNavigator.navigate(
         project.owner,

src/features/projects/domain/ProjectNavigator.ts

@@ -1,4 +1,5 @@
 import Project from "./Project"
+import { getDefaultSpecification } from "./Version"
 
 interface IPathnameReader {
   readonly pathname: string
@@ -36,7 +37,7 @@ export default class ProjectNavigator {
     if (candidateSpecification) {
       this.router.push(`/${project.owner}/${project.name}/${newVersion.id}/${candidateSpecification.id}`)
     } else {
-      const defaultOrFirstSpecification = newVersion.specifications.find(spec => spec.isDefault) || newVersion.specifications[0]
+      const defaultOrFirstSpecification = getDefaultSpecification(newVersion)
       this.router.push(`/${project.owner}/${project.name}/${newVersion.id}/${defaultOrFirstSpecification.id}`)
     }
   }

src/features/projects/domain/Version.ts

@@ -12,3 +12,7 @@ export const VersionSchema = z.object({
 type Version = z.infer<typeof VersionSchema>
 
 export default Version
+
+export function getDefaultSpecification(version: Version) {
+  return version.specifications.find((spec) => spec.isDefault) || version.specifications[0]
+}

src/features/projects/domain/getProjectSelectionFromPath.ts

@@ -1,5 +1,5 @@
 import Project from "./Project"
-import Version from "./Version"
+import Version, { getDefaultSpecification } from "./Version"
 import OpenApiSpecification from "./OpenApiSpecification"
 
 export default function getProjectSelectionFromPath({
@@ -61,7 +61,7 @@ export default function getProjectSelectionFromPath({
   if (specificationId && !didMoveSpecificationIdToVersionId) {
     specification = version.specifications.find(e => e.id == specificationId)
   } else if (version.specifications.length > 0) {
-    specification = version.specifications.find(spec => spec.isDefault) || version.specifications[0]
+    specification = getDefaultSpecification(version)
   }
   return { project, version, specification }
 }

src/features/projects/domain/index.ts

@@ -16,3 +16,4 @@ export { default as ProjectNavigator } from "./ProjectNavigator"
 export { default as ProjectRepository } from "./ProjectRepository"
 export { default as updateWindowTitle } from "./updateWindowTitle"
 export type { default as Version } from "./Version"
+export { getDefaultSpecification } from "./Version"