Merge pull request #645 from shapehq/hotfix/preserve-scroll-on-project-refresh

Hotfix/preserve scroll on project refresh

Author: ulrikandersen

__test__/projects/GitHubProjectDataSource.test.ts

@@ -845,11 +845,13 @@ test("It adds remote versions from the project configuration", async () => {
       id: "huey",
       name: "Huey",
       url: `/api/remotes/${base64RemoteConfigEncoder.encode({ url: "https://example.com/huey.yml" })}`,
+      urlHash: "89ba381286214eec",
       isDefault: false
     }, {
       id: "dewey",
       name: "Dewey",
       url: `/api/remotes/${base64RemoteConfigEncoder.encode({ url: "https://example.com/dewey.yml" })}`,
+      urlHash: "8f810fff152505f6",
       isDefault: false
     }]
   }, {
@@ -860,6 +862,7 @@ test("It adds remote versions from the project configuration", async () => {
       id: "louie",
       name: "Louie",
       url: `/api/remotes/${base64RemoteConfigEncoder.encode({ url: "https://example.com/louie.yml" })}`,
+      urlHash: "b83ebf43ceede6bc",
       isDefault: false
     }]
   }])
@@ -925,6 +928,7 @@ test("It modifies ID of remote version if the ID already exists", async () => {
       id: "baz",
       name: "Baz",
       url: `/api/remotes/${base64RemoteConfigEncoder.encode({ url: "https://example.com/baz.yml" })}`,
+      urlHash: "25cb42ff63570cb5",
       isDefault: false
     }]
   }, {
@@ -935,6 +939,7 @@ test("It modifies ID of remote version if the ID already exists", async () => {
       id: "hello",
       name: "Hello",
       url: `/api/remotes/${base64RemoteConfigEncoder.encode({ url: "https://example.com/hello.yml" })}`,
+      urlHash: "d078bd689699d1f0",
       isDefault: false
     }]
   }])
@@ -979,6 +984,7 @@ test("It lets users specify the ID of a remote version", async () => {
       id: "baz",
       name: "Baz",
       url: `/api/remotes/${base64RemoteConfigEncoder.encode({ url: "https://example.com/baz.yml" })}`,
+      urlHash: "25cb42ff63570cb5",
       isDefault: false
     }]
   }])
@@ -1023,6 +1029,7 @@ test("It lets users specify the ID of a remote specification", async () => {
       id: "some-spec",
       name: "Baz",
       url: `/api/remotes/${base64RemoteConfigEncoder.encode({ url: "https://example.com/baz.yml" })}`,
+      urlHash: "25cb42ff63570cb5",
       isDefault: false
     }]
   }])

src/features/projects/data/GitHubProjectDataSource.ts

@@ -1,3 +1,4 @@
+import { createHash } from "crypto"
 import { IEncryptionService } from "@/features/encrypt/EncryptionService"
 import {
   Project,
@@ -218,11 +219,14 @@ export default class GitHubProjectDataSource implements IProjectDataSource {
         };
 
         const encodedRemoteConfig = this.remoteConfigEncoder.encode(remoteConfig);
+        // 16 hex chars (64 bits) - sufficient for change detection, not cryptographic security
+        const configHash = createHash("sha256").update(JSON.stringify(remoteConfig)).digest("hex").slice(0, 16);
 
         return {
           id: this.makeURLSafeID((e.id || e.name).toLowerCase()),
           name: e.name,
           url: `/api/remotes/${encodedRemoteConfig}`,
+          urlHash: configHash,
           isDefault: false // initial value
         };
       })

src/features/projects/domain/OpenApiSpecification.ts

@@ -4,6 +4,7 @@ export const OpenApiSpecificationSchema = z.object({
   id: z.string(),
   name: z.string(),
   url: z.string(),
+  urlHash: z.string().optional(),
   editURL: z.string().optional(),
   diffURL: z.string().optional(),
   diffBaseBranch: z.string().optional(),

src/features/projects/view/ProjectsContextProvider.tsx

@@ -15,19 +15,20 @@ const ProjectsContextProvider = ({
   const [refreshing, setRefreshing] = useState(false);
   const isLoadingRef = useRef(false);
 
-
-  const setProjectsAndRefreshed = (value: Project[]) => {
-    setProjects(value);
-  };
+  // Fingerprint uses urlHash for remote specs (stable), URL for others (already stable)
+  const fingerprint = (list: Project[]) =>
+    list.flatMap(p => p.versions.flatMap(v => v.specifications.map(s => s.urlHash ?? s.url))).sort().join();
 
 const refreshProjects = useCallback(() => {
   if (isLoadingRef.current) return;
   isLoadingRef.current = true;
   setRefreshing(true);
   fetch("/api/refresh-projects", { method: "POST" })
     .then((res) => res.json())
-    .then(({ projects }) => {
-      if (projects) setProjectsAndRefreshed(projects);
+    .then(({ projects: newProjects }) => {
+      if (newProjects) {
+        setProjects(prev => fingerprint(prev) === fingerprint(newProjects) ? prev : newProjects);
+      }
     })
     .catch((error) => console.error("Failed to refresh projects", error))
     .finally(() => {