Use refreshing state to show loading #603
Merged
+23
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
while project cache is refreshed
ulrikandersen
commented
Sep 29, 2025
| const [refreshed, setRefreshed] = useState<boolean>(true); | ||
| const [projects, setProjects] = useState<Project[]>(initialProjects || []); | ||
| const isLoadingRef = useRef(false); | ||
| const [refreshing, setRefreshing] = useState(false); |
Contributor
Author
There was a problem hiding this comment.
Perhaps we do not need const isLoadingRef = useRef(false)?
oscarlund121
merged commit 315a43e
into
optimize-project-doc-loadtime
3 of 5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses "refreshing" state to show loading indicator while project cache is being refreshed. This is especially useful when the user is requesting a project, branch og spec that is not in the cache.
The PR removes the
SecondaryHeaderPlaceholderand just shows the main loading indicator.Demo:
Skaermoptagelse.2025-09-29.kl.20.57.12.mov