Skip to content

Commit bffd1c6

Browse files
committed
Merge pull request #8 from AFaust/mavenization
Removed dependency on RhinoScriptProcessor and index-based queries
2 parents f2b2687 + 787e55f commit bffd1c6

File tree

4 files changed

+11
-17
lines changed

4 files changed

+11
-17
lines changed

javascript-console-repo/src/main/amp/config/alfresco/extension/fme-jsconsole-context.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
<property name="transactionService" ref="transactionService"/>
88
<property name="preRollScriptResource" value="classpath:de/fme/jsconsole/jsconsole-pre-roll-script.js" />
99
<property name="postRollScriptResource" value="classpath:de/fme/jsconsole/jsconsole-post-roll-script.js" />
10-
<property name="rhinoScriptProcessor" ref="javaScriptProcessor" />
1110
</bean>
1211

1312
</beans>

javascript-console-repo/src/main/amp/config/alfresco/extension/templates/webscripts/de/fme/jsconsole/createscript.put.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11

2-
var scriptFolder = search.xpathSearch("/app:company_home/app:dictionary/app:scripts")[0];
2+
var scriptFolder = companyhome.childrenByXPath("app:dictionary/app:scripts")[0];
33
if (scriptFolder) {
44
var scriptNode = scriptFolder.createFile(args.name);
55
scriptNode.content = requestbody.content;

javascript-console-repo/src/main/amp/config/alfresco/extension/templates/webscripts/de/fme/jsconsole/listscripts.get.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ function findScripts(folder) {
2424
return scriptlist;
2525
}
2626

27-
var scriptFolder = search.xpathSearch("/app:company_home/app:dictionary/app:scripts")[0];
27+
var scriptFolder = companyhome.childrenByXPath("app:dictionary/app:scripts")[0];
2828
if (scriptFolder) {
2929
model.scripts = jsonUtils.toJSONString(findScripts(scriptFolder));
3030
}

javascript-console-repo/src/main/java/de/fme/jsconsole/ExecuteWebscript.java

Lines changed: 9 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -9,24 +9,24 @@
99
import java.io.StringWriter;
1010
import java.io.Writer;
1111
import java.nio.charset.Charset;
12+
import java.text.MessageFormat;
1213
import java.util.HashMap;
1314
import java.util.List;
1415
import java.util.Map;
1516

16-
import org.alfresco.repo.jscript.RhinoScriptProcessor;
1717
import org.alfresco.repo.jscript.ScriptNode;
1818
import org.alfresco.repo.jscript.ScriptUtils;
1919
import org.alfresco.repo.security.authentication.AuthenticationUtil;
2020
import org.alfresco.repo.security.permissions.AccessDeniedException;
2121
import org.alfresco.repo.transaction.RetryingTransactionHelper.RetryingTransactionCallback;
22-
import org.alfresco.scripts.ScriptResourceHelper;
2322
import org.alfresco.service.cmr.repository.NodeRef;
2423
import org.alfresco.service.transaction.TransactionService;
2524
import org.alfresco.util.MD5;
2625
import org.apache.commons.io.IOUtils;
2726
import org.apache.commons.lang.StringUtils;
2827
import org.apache.commons.logging.Log;
2928
import org.apache.commons.logging.LogFactory;
29+
import org.springframework.core.io.ClassPathResource;
3030
import org.springframework.core.io.Resource;
3131
import org.springframework.extensions.webscripts.AbstractWebScript;
3232
import org.springframework.extensions.webscripts.Cache;
@@ -56,15 +56,13 @@ public class ExecuteWebscript extends AbstractWebScript {
5656

5757
private TransactionService transactionService;
5858

59-
private Resource preRollScriptResource;
59+
private ClassPathResource preRollScriptResource;
6060

6161
private String preRollScript = "";
6262

63-
private Resource postRollScriptResource;
63+
private ClassPathResource postRollScriptResource;
6464

6565
private String postRollScript = "";
66-
67-
private RhinoScriptProcessor rhinoScriptProcessor;
6866

6967
@Override
7068
public void init(Container container, Description description) {
@@ -89,9 +87,10 @@ public void execute(WebScriptRequest request, WebScriptResponse response) throws
8987

9088
JavascriptConsoleRequest jsreq = JavascriptConsoleRequest.readJson(request);
9189

92-
String script = ScriptResourceHelper.resolveScriptImports(jsreq.script, rhinoScriptProcessor, log);
90+
final String script = MessageFormat.format("<import resource=\"classpath:{0}\">",
91+
this.preRollScriptResource.getPath()) + jsreq.script;
9392

94-
ScriptContent scriptContent = new StringScriptContent(preRollScript + script + "\n" + postRollScript);
93+
ScriptContent scriptContent = new StringScriptContent(script + "\n" + postRollScript);
9594
JavascriptConsoleResult result = runScriptWithTransactionAndAuthentication(request, response, jsreq, scriptContent);
9695

9796
if (!result.isStatusResponseSent()) {
@@ -315,17 +314,13 @@ public void setTransactionService(TransactionService transactionService) {
315314
this.transactionService = transactionService;
316315
}
317316

318-
public void setPostRollScriptResource(Resource postRollScriptResource) {
317+
public void setPostRollScriptResource(ClassPathResource postRollScriptResource) {
319318
this.postRollScriptResource = postRollScriptResource;
320319
}
321320

322-
public void setPreRollScriptResource(Resource preRollScriptResource) {
321+
public void setPreRollScriptResource(ClassPathResource preRollScriptResource) {
323322
this.preRollScriptResource = preRollScriptResource;
324323
}
325-
326-
public void setRhinoScriptProcessor(RhinoScriptProcessor rhinoScriptProcessor) {
327-
this.rhinoScriptProcessor = rhinoScriptProcessor;
328-
}
329324

330325
private static class StringScriptContent implements ScriptContent {
331326
private final String content;

0 commit comments

Comments
 (0)