Fix web-tier percent-encoding in OAuth connector. Brackets and other invalid characters are now encoded correctly.

git-svn-id: https://share-extras.googlecode.com/svn/trunk/Share OAuth@655 a3f5c567-fd0f-3a89-9b71-a290c5a5f590

Author: wabson

source/java/org/sharextras/webscripts/connector/HttpOAuthConnector.java

@@ -247,6 +247,13 @@ private void applyAuthParams(Map<String, String> authParams)
 		}
     }
 
+    /**
+     * Percent-encode a parameter for construction of the base string and the Authorization header, 
+     * as specified in http://tools.ietf.org/html/rfc5849#section-3.6
+     * 
+     * @param p Unencoded string
+     * @return Encoded text
+     */
     private String encodeParameter(String p)
     {
     	String encoded = URLEncoder.encodeUriComponent(p);
@@ -261,7 +268,8 @@ private String encodeParameter(String p)
 			lastEnd = m.end();
 		}
     	sb.append(encoded.substring(lastEnd));
-		return sb.toString();
+		return sb.toString().replaceAll("!", "%21").replaceAll("\\(", "%28").replaceAll("\\)", "%29")
+			.replaceAll("\\*", "%2A");
     }
 
     @SuppressWarnings("unchecked")