suspect SBCL declaim optimize form

[slyrus]

There's a (declaim (optimize (debug 2))) form at the top of node.lisp. I think this is an attempt to ensure that tail calls are optimized so that we don't blow the stack. The problem is that this doesn't take effect when the compiler policy is restricted and may lead to globally setting the optimization forms (the spec says its undefined if this happens).

Thoughts on how to fix this?

[ruricolist]

I deleted this and all the similar declaim forms from STP years ago in FXML, and never missed them.

According to git-blame the declaim forms have always been there. Since (debug 2) is the default, my guess was that STP was written in an environment with non-standard global optimization declarations in effect, and the declaim forms were included during development and never removed.