Load all replay frame cells into memory instead of only 8 (read more)

We ran into a fun bug with srcwr💾.
If you used https://github.com/KawaiiClan/bhoptimer-savestate and then
got a WR replay with the run: the replay would be FUCKED.

Why:
- srcwr💾 reinterprets the ArrayList memory using the blocksize.
  This means that it writes out 8 cells a frame when frames originate from ReadReplayFrames().
- sourcepawn version tries to read 10 cells from the ArrayList,
  only reads 8 into the buffer, then writes 10 cells (with two cells being zero) to the replay file.

If we read 10 cells into memory, a 5h replay would be 14.4MB more in memory than before.
That's fine.  Fuck it.

This was a bit annoying to track down.

Author: rtldg

addons/sourcemod/scripting/include/shavit/replay-file.inc

@@ -120,27 +120,23 @@ stock bool LoadReplayCache(frame_cache_t cache, int style, int track, const char
 stock bool ReadReplayFrames(File file, replay_header_t header, frame_cache_t cache)
 {
 	int total_cells = 6;
-	int used_cells = 6;
 	bool is_btimes = false;
 
 	if (header.iReplayVersion > 0x01)
 	{
 		total_cells = 8;
-		used_cells = 8;
 	}
 
-	// We have differing total_cells & used_cells because we want to save memory during playback since the latest two cells added (vel & mousexy) aren't needed and are only useful for replay file anticheat usage stuff....
 	if (header.iReplayVersion >= 0x06)
 	{
 		total_cells = 10;
-		used_cells = 8;
 	}
 
 	any aReplayData[sizeof(frame_t)];
 
 	delete cache.aFrames;
 	int iTotalSize = header.iFrameCount + header.iPreFrames + header.iPostFrames;
-	cache.aFrames = new ArrayList(used_cells, iTotalSize);
+	cache.aFrames = new ArrayList(total_cells, iTotalSize);
 
 	if (!header.sReplayFormat[0]) // old replay format. no header.
 	{
@@ -177,7 +173,7 @@ stock bool ReadReplayFrames(File file, replay_header_t header, frame_cache_t cac
 		{
 			if(file.Read(aReplayData, total_cells, 4) >= 0)
 			{
-				cache.aFrames.SetArray(i, aReplayData, used_cells);
+				cache.aFrames.SetArray(i, aReplayData);
 
 				if (is_btimes && (aReplayData[5] & IN_BULLRUSH))
 				{