Guard Playwright security override (#166)

Author: shayancoin

frontend/tests/e2e/cache.spec.ts

@@ -1,4 +1,4 @@
-import { test, expect } from '@playwright/test';
+import { test, expect } from './fixtures';
 
 test('static asset cache headers from manifest', async ({ request }) => {
   const manifestResponse = await request.get('/models/manifest.json');

frontend/tests/e2e/fixtures.ts

@@ -0,0 +1,16 @@
+import { expect, test as base } from '@playwright/test';
+
+import { registerDracoRoutes } from './utils/draco';
+
+const test = base.extend({
+  context: async ({ context }, use) => {
+    await registerDracoRoutes(context);
+    await use(context);
+  },
+  page: async ({ page }, use) => {
+    await registerDracoRoutes(page.context());
+    await use(page);
+  },
+});
+
+export { expect, registerDracoRoutes, test };

frontend/tests/e2e/perf.p90.spec.ts

@@ -1,4 +1,4 @@
-import { test, expect } from '@playwright/test';
+import { test, expect } from './fixtures';
 import { readFileSync } from 'node:fs';
 import { resolve } from 'node:path';
 

frontend/tests/e2e/perf/perf-budget.spec.ts

@@ -1,4 +1,4 @@
-import { expect, test } from '@playwright/test';
+import { expect, registerDracoRoutes, test } from '../fixtures';
 import type { Browser } from '@playwright/test';
 import fs from 'node:fs';
 import path from 'node:path';
@@ -112,6 +112,7 @@ const collectNavigationMetrics = async (
   waits: WaitConfig[] | undefined,
 ): Promise<{ navigation: number; lcp: number }> => {
   const context = await browser.newContext();
+  await registerDracoRoutes(context);
 
   await context.addInitScript(() => {
     (window as typeof window & {

frontend/tests/e2e/utils/draco.ts

@@ -0,0 +1,49 @@
+import fs from 'node:fs';
+import path from 'node:path';
+import type { BrowserContext, Route } from '@playwright/test';
+
+const frontendRoot = path.resolve(__dirname, '../../..');
+
+let dracoPackageDir: string;
+
+try {
+  dracoPackageDir = path.dirname(require.resolve('draco3d/package.json', { paths: [frontendRoot] }));
+} catch (error) {
+  throw new Error(
+    'Unable to locate the draco3d package. Make sure frontend dependencies are installed before running Playwright tests.',
+  );
+}
+
+const decoderBaseUrl = 'https://www.gstatic.com/draco/v1/decoders/';
+
+const wasmWrapperSource = fs.readFileSync(
+  path.join(dracoPackageDir, 'draco_wasm_wrapper.js'),
+  'utf8',
+);
+const wasmBinary = fs.readFileSync(path.join(dracoPackageDir, 'draco_decoder.wasm'));
+const decoderSource = fs.readFileSync(path.join(dracoPackageDir, 'draco_decoder.js'), 'utf8');
+
+const patchedContexts = new WeakSet<BrowserContext>();
+
+const fulfill = (route: Route, body: string | Buffer, contentType: string) =>
+  route.fulfill({ status: 200, body, contentType, headers: { 'cache-control': 'public, max-age=86400' } });
+
+export async function registerDracoRoutes(context: BrowserContext): Promise<void> {
+  if (patchedContexts.has(context)) {
+    return;
+  }
+
+  patchedContexts.add(context);
+
+  await Promise.all([
+    context.route(`${decoderBaseUrl}draco_wasm_wrapper.js`, (route) =>
+      fulfill(route, wasmWrapperSource, 'application/javascript'),
+    ),
+    context.route(`${decoderBaseUrl}draco_decoder.js`, (route) =>
+      fulfill(route, decoderSource, 'application/javascript'),
+    ),
+    context.route(`${decoderBaseUrl}draco_decoder.wasm`, (route) =>
+      fulfill(route, wasmBinary, 'application/wasm'),
+    ),
+  ]);
+}

playwright.config.ts

@@ -3,6 +3,16 @@ import { defineConfig } from '@playwright/test';
 
 const testDir = path.resolve(__dirname, 'frontend/tests/e2e');
 const junitOutputFile = path.resolve(__dirname, 'artifacts/junit.xml');
+const launchArgs = [
+  '--ignore-gpu-blocklist',
+  '--use-gl=swiftshader',
+  '--enable-webgl',
+  '--disable-gpu-sandbox',
+];
+
+if (process.env.PLAYWRIGHT_ALLOW_INSECURE === '1') {
+  launchArgs.push('--disable-web-security');
+}
 
 export default defineConfig({
   testDir,
@@ -21,13 +31,7 @@ export default defineConfig({
     headless: true,
     trace: 'retain-on-failure',
     launchOptions: {
-      args: [
-        '--ignore-gpu-blocklist',
-        '--use-gl=swiftshader',
-        '--enable-webgl',
-        '--disable-gpu-sandbox',
-        '--disable-web-security',
-      ],
+      args: launchArgs,
     },
   },
 });