Skip to content

Commit ec61914

Browse files
authored
Merge pull request #1606 from sheinsight/fix/ui-issues-0123
fix: 修复多个组件的 UI 验收问题
2 parents 8dd7c1a + 009cb63 commit ec61914

File tree

41 files changed

+248
-33
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

41 files changed

+248
-33
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "sheinx",
33
"private": true,
4-
"version": "3.9.8",
4+
"version": "3.9.9-beta.1",
55
"description": "A react library developed with sheinx",
66
"module": "dist/index.js",
77
"types": "dist/index.d.ts",

packages/base/src/collapse/collapse-item.tsx

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,10 +43,11 @@ const CollapseItem = (props: CollapseItemProps) => {
4343
disabled,
4444
onChange,
4545
});
46-
const headerIconItem = () => {
46+
const headerIconItem = (direction: 'left' | 'right') => {
4747
const collapseItemIconClassName = classNames(
4848
jssStyle?.collapseItem.icon,
4949
jssStyle?.collapseItem.activeTransform,
50+
direction === 'right' && jssStyle?.collapseItem.iconRight,
5051
// expandIconPosition === 'right'
5152
// ? jssStyle?.collapseItem.activeTransformRight
5253
// : jssStyle?.collapseItem.activeTransform,
@@ -112,7 +113,7 @@ const CollapseItem = (props: CollapseItemProps) => {
112113
return (
113114
<div className={collapseItemClassName} style={style}>
114115
<div {...getItemContentProps({ className: collapseItemHeaderClassName })}>
115-
{expandIconPosition === 'left' && headerIconItem()}
116+
{expandIconPosition === 'left' && headerIconItem('left')}
116117
{extraPosition === 'left' && extraItem()}
117118
<div
118119
{...getTitleProps({
@@ -125,7 +126,7 @@ const CollapseItem = (props: CollapseItemProps) => {
125126
{title}
126127
</div>
127128
{extraPosition === 'right' && extraItem()}
128-
{expandIconPosition === 'right' && headerIconItem()}
129+
{expandIconPosition === 'right' && headerIconItem('right')}
129130
</div>
130131
{renderContent()}
131132
</div>

packages/base/src/collapse/collapse-item.type.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ export interface CollapseItemClasses {
1111
header: string;
1212
active: string;
1313
icon: string;
14+
iconRight: string;
1415
title: string;
1516
extra: string;
1617
content: string;

packages/base/src/icons/config.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ const config = {
9090
InfoLine: icons.InfoCircleFill,
9191
WarningLine: icons.WarningCircleFill,
9292
SuccessLine: icons.CheckCircleFill,
93-
DangerLine: icons.Close,
93+
DangerLine: icons.CloseFill,
9494
},
9595
rate: {
9696
Star: icons.StarFill,

packages/base/src/modal/modal-content.tsx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ import { FormFooterProvider } from '../form/form-footer-context';
99
import { popupContext } from '@sheinx/hooks';
1010

1111
import type { ModalContentProps } from './modal-content.type';
12+
import { useConfig } from '../config';
1213

1314
let hasMask = false;
1415

@@ -102,6 +103,7 @@ const Modal = (props: ModalContentProps) => {
102103
const defaultWidth = isPositionX ? 'auto' : 500;
103104
const { events = {}, maskCloseAble = true, esc = true, top = '10vh', style = {} } = props;
104105

106+
const globalConfig = useConfig()
105107
const width = style.width || props.width || defaultWidth;
106108
const height = style.height || props.height;
107109
const [origin, setOrigin] = useState('');
@@ -508,6 +510,7 @@ const Modal = (props: ModalContentProps) => {
508510
)}
509511
onAnimationEnd={handleAnimationEnd}
510512
style={{ background: props.maskBackground, zIndex: props.zIndex, display: !visible && !animation ? 'none' : undefined }}
513+
dir={globalConfig.direction}
511514
>
512515
<div
513516
className={modalClasses?.mask}

packages/base/src/select/list-columns.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ const ColumnsList = <DataItem, Value>(props: BaseListProps<DataItem, Value>) =>
102102
if (item[groupKey]) {
103103
const title = item[groupKey];
104104
return (
105-
<div className={styles.optionGroupTitle} key={key} title={typeof title === 'string' ? title as string : undefined}>
105+
<div className={styles.optionGroupTitle} key={key} title={typeof title === 'string' ? title as string : undefined} style={{ height: 'var(--group-title-height)' }}>
106106
{title as React.ReactNode}
107107
</div>
108108
);

packages/base/src/select/list.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@ const List = <DataItem, Value>(props: BaseListProps<DataItem, Value>) => {
178178
const renderGroupTitle = (d: { [key: string]: any }) => {
179179
const title = d[groupKey as keyof typeof d];
180180
return (
181-
<div className={styles.optionGroupTitle} title={typeof title === 'string' ? title : undefined}>
181+
<div className={styles.optionGroupTitle} title={typeof title === 'string' ? title : undefined} style={{ height: 'var(--group-title-height)' }}>
182182
{title}
183183
</div>
184184
);
@@ -217,7 +217,7 @@ const List = <DataItem, Value>(props: BaseListProps<DataItem, Value>) => {
217217
}
218218
}, []);
219219

220-
return <div className={rootClass}>{renderList()}</div>;
220+
return <div className={rootClass} style={{ '--group-title-height': `${lineHeight - 2}px` } as React.CSSProperties}>{renderList()}</div>;
221221
};
222222

223223
export default List;

packages/shineout-style/src/collapse/collapse-item.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,10 @@ const collapseItemStyle: JsStyles<CollapseItemClassType> = {
9494
},
9595
}
9696
},
97+
iconRight: {
98+
marginRight: 0,
99+
marginLeft: Token.collapseHeaderGap,
100+
},
97101
title: {
98102
flex: 1,
99103
lineHeight: Token.lineHeightDynamic,

packages/shineout-style/src/inner-title/inner-title.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import { JsStyles } from '../jss-style';
22
import token from '@sheinx/theme';
33
import { InnerTitleClasses } from '@sheinx/base';
4+
import { getTokenName } from '@sheinx/theme';
45

56
const moveOffset = '-10px';
67
const moveTime = '120ms';

packages/shineout-style/src/input/input-border.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import { getTokenName } from '@sheinx/theme';
12
import type { CSSProperties } from 'react';
23

34
const supportsHas = () => {
@@ -216,6 +217,8 @@ export default <T extends string>(name: T, token: Token = {} as any) => {
216217
borderColor: token.disabledBorderColor,
217218
boxShadow: 'none',
218219
cursor: 'not-allowed',
220+
[getTokenName('inputInnerPlaceFontColor')]: token.disabledFontColor,
221+
[getTokenName('inputInnerFontColor')]: token.disabledFontColor,
219222
[`&:not($${name}Error):hover`]: {
220223
borderColor: token.disabledBorderColor,
221224
},

0 commit comments

Comments
 (0)