chore: bump package_json_parser version to 0.0.7 and improve error handling in package.json parsing

Author: ityuany

Cargo.toml

@@ -108,7 +108,7 @@ indicatif = "0.17.8"
 flate2              = "1.0.28"
 glob                = "0.3.2"
 once_cell           = "1.20.2"
-package_json_parser = "0.0.6"
+package_json_parser = "0.0.7"
 strum               = { version = "0.27.1", features = ["derive"] }
 tar                 = "0.4.40"
 tempfile            = "=3.16.0"

crates/package_manager/src/resolver.rs

@@ -37,9 +37,13 @@ impl PackageManagerResolver {
           if acc.is_some() {
             return Ok(acc);
           }
-          let package_json = PackageJsonParser::parse(item)?;
 
-          Ok(package_json.package_manager)
+          let res = PackageJsonParser::parse(item).map_err(|e| {
+            eprintln!("{:?}", e);
+            anyhow::anyhow!("parse package.json failed, err: {:?}", e)
+          })?;
+
+          return Ok(res.package_manager);
         })?;
 
     if let Some(raw) = package_manager {

crates/shim/src/pm_shim.rs

@@ -65,15 +65,14 @@ impl PmShim {
 
     let dir = resolver.ensure_package_manager(&package_manager).await?;
 
-    let Ok(json) = PackageJsonParser::parse(dir.join("package.json")) else {
-      bail!("Failed to parse package.json");
-    };
-
-    // let json = PJson::from(dir)?;
-
-    let map = json.bin_to_hash_map()?;
-
-    // let x = map.get(bin_name);
+    let json = PackageJsonParser::parse(dir.join("package.json")).map_err(|e| {
+      eprintln!("{:?}", e);
+      anyhow::anyhow!("parse package.json failed, err: {:?}", e)
+    })?;
+
+    let map = json
+      .bin_to_hash_map()
+      .map_err(|e| anyhow::anyhow!("{}", e))?;
 
     if let Some(file) = map.get(bin_name) {
       let file = dir.join(file);

crates/test_utils/src/lib.rs

@@ -341,6 +341,10 @@ is: {}
 
     let res = self.snapshots.join("\n");
 
+    let current_dir = current_dir().unwrap();
+
+    let res = res.replace(&current_dir.display().to_string(), ".");
+
     f(&res);
 
     Ok(())

e2e/tests/snapshots/snm_test____test_context_wrapped_test_package_json_parse_err.snap

@@ -7,5 +7,31 @@ is: snm i
 
 
 stdout:
-stderr:Error: invalid type: string "true", expected a boolean at line 3 column 19
+stderr:package_json::json_parse_failed (https://docs.rs/package_json_parser/0.0.7/package_json_parser/enum.ErrorKind.html#variant.JsonParseError)
+
+  × JSON parsing failed
+  ╰─▶ invalid type: string "true", expected a boolean at line 3 column 19
+   ╭─[./tests/fixtures/package_json_parse_err/package.json:1:1]
+ 1 │ ╭─▶ {
+ 2 │ │     "packageManager": "pnpm@9.14.2",
+ 3 │ │     "private": "true"
+   · │   ─────────┬─────────
+   · │            ╰── here
+ 4 │ ╰─▶ }
+   ╰────
+  help: Please check the JSON syntax
+
+Error: parse package.json failed, err: package_json::json_parse_failed (https://docs.rs/package_json_parser/0.0.7/package_json_parser/enum.ErrorKind.html#variant.JsonParseError)
+
+  × JSON parsing failed
+  ╰─▶ invalid type: string "true", expected a boolean at line 3 column 19
+   ╭─[./tests/fixtures/package_json_parse_err/package.json:1:1]
+ 1 │ ╭─▶ {
+ 2 │ │     "packageManager": "pnpm@9.14.2",
+ 3 │ │     "private": "true"
+   · │   ─────────┬─────────
+   · │            ╰── here
+ 4 │ ╰─▶ }
+   ╰────
+  help: Please check the JSON syntax
 status:1

e2e/tests/snapshots/snm_test____test_context_wrapped_test_snm_install_with_invalid_private_package_json.snap

@@ -7,5 +7,41 @@ is: snm i
 
 
 stdout:
-stderr:Error: invalid type: string "true", expected a boolean at line 5 column 18
+stderr:package_json::json_parse_failed (https://docs.rs/package_json_parser/0.0.7/package_json_parser/enum.ErrorKind.html#variant.JsonParseError)
+
+  × JSON parsing failed
+  ╰─▶ invalid type: string "true", expected a boolean at line 5 column 18
+   ╭─[./tests/fixtures/invalid_package_json/package.json:1:1]
+ 1 │ ╭─▶ {
+ 2 │ │     "name": "snm_i",
+ 3 │ │     "version": "1.0.0",
+ 4 │ │     "packageManager": "pnpm@9.0.0",
+ 5 │ │     "private":"true",
+   · │   ─────────┬─────────
+   · │            ╰── here
+ 6 │ │     "dependencies": {
+ 7 │ │       "react": "18.3.1"
+ 8 │ │     }
+ 9 │ ╰─▶ }
+   ╰────
+  help: Please check the JSON syntax
+
+Error: parse package.json failed, err: package_json::json_parse_failed (https://docs.rs/package_json_parser/0.0.7/package_json_parser/enum.ErrorKind.html#variant.JsonParseError)
+
+  × JSON parsing failed
+  ╰─▶ invalid type: string "true", expected a boolean at line 5 column 18
+   ╭─[./tests/fixtures/invalid_package_json/package.json:1:1]
+ 1 │ ╭─▶ {
+ 2 │ │     "name": "snm_i",
+ 3 │ │     "version": "1.0.0",
+ 4 │ │     "packageManager": "pnpm@9.0.0",
+ 5 │ │     "private":"true",
+   · │   ─────────┬─────────
+   · │            ╰── here
+ 6 │ │     "dependencies": {
+ 7 │ │       "react": "18.3.1"
+ 8 │ │     }
+ 9 │ ╰─▶ }
+   ╰────
+  help: Please check the JSON syntax
 status:1