Don't read from /dev/[u]random on GitHub Actions

Author: beccasaurus

.github/workflows/ubuntu20.yml

@@ -14,11 +14,8 @@ jobs:
       - uses: actions/checkout@v2
       - run: 'bash --version | head -1'
         shell: bash
-      - run: echo Will read from random
+      - run: bin/spec
         shell: bash
-      - run: cat /dev/random | base64 | tr -dc 'a-zA-Z0-9' | fold -w 32 | head -n 1
-        shell: bash
-      - run: echo Next read from urandom
-        shell: bash
-      - run: cat /dev/urandom | base64 | tr -dc 'a-zA-Z0-9' | fold -w 32 | head -n 1
-        shell: bash
+        env:
+          VERBOSE: true
+          SHELLPEN_URANDOM: false

shellpen.sh

@@ -1145,9 +1145,9 @@ shellpen() {
               [ "$existingPenName" = "$penName" ] && { echo "shellpen pens new: pen already exists '$penName'" >&2; return 1; }
             done
 
-            if [ -n "$SHELLPEN_RANDOM_SOURCE" ] # This is specifically to support GitHub Actions which blocks on urandom
+            if [ "$SHELLPEN_URANDOM" = false ] # This is specifically to support GitHub Actions which blocks on /dev/urandom
             then
-              local sourceId="$( cat $SHELLPEN_RANDOM_SOURCE | base64 | tr -dc 'a-zA-Z0-9' | fold -w 32 | head -n 1 )"
+              local sourceId="${RANDOM}${RANDOM}${RANDOM}"
             else
               local sourceId="$( cat /dev/urandom | base64 | tr -dc 'a-zA-Z0-9' | fold -w 32 | head -n 1 )"
             fi

src/pens/new.sh

@@ -9,9 +9,9 @@ do
   [ "$existingPenName" = "$penName" ] && { echo "!command: pen already exists '$penName'" >&2; return 1; }
 done
 
-if [ -n "$SHELLPEN_RANDOM_SOURCE" ] # This is specifically to support GitHub Actions which blocks on urandom
+if [ "$SHELLPEN_URANDOM" = false ] # This is specifically to support GitHub Actions which blocks on /dev/urandom
 then
-  local sourceId="$( cat $SHELLPEN_RANDOM_SOURCE | base64 | tr -dc 'a-zA-Z0-9' | fold -w 32 | head -n 1 )"
+  local sourceId="${RANDOM}${RANDOM}${RANDOM}"
 else
   local sourceId="$( cat /dev/urandom | base64 | tr -dc 'a-zA-Z0-9' | fold -w 32 | head -n 1 )"
 fi