fix(api): evaluate cloud namespace limits before enterprise' one

Author: henrybarreto

api/services/device.go

@@ -322,10 +322,6 @@ func (s *service) UpdateDeviceStatus(ctx context.Context, tenant string, uid mod
 	}
 
 	switch {
-	case envs.IsCommunity(), envs.IsEnterprise():
-		if namespace.HasMaxDevices() && namespace.HasMaxDevicesReached() {
-			return NewErrDeviceMaxDevicesReached(namespace.MaxDevices)
-		}
 	case envs.IsCloud():
 		if namespace.Billing.IsActive() {
 			if err := s.BillingReport(s.client, namespace.TenantID, ReportDeviceAccept); err != nil {
@@ -362,6 +358,10 @@ func (s *service) UpdateDeviceStatus(ctx context.Context, tenant string, uid mod
 				return ErrDeviceLimit
 			}
 		}
+	case envs.IsCommunity(), envs.IsEnterprise():
+		if namespace.HasMaxDevices() && namespace.HasMaxDevicesReached() {
+			return NewErrDeviceMaxDevicesReached(namespace.MaxDevices)
+		}
 	}
 
 	if err := s.store.DeviceUpdateStatus(ctx, uid, status); err != nil {

api/services/device_test.go

@@ -2330,7 +2330,7 @@ func TestUpdateDeviceStatus_community_and_enterprise(t *testing.T) {
 				envMock.
 					On("Get", "SHELLHUB_CLOUD").
 					Return("false").
-					Once()
+					Twice()
 				envMock.
 					On("Get", "SHELLHUB_ENTERPRISE").
 					Return("false").
@@ -2398,7 +2398,7 @@ func TestUpdateDeviceStatus_community_and_enterprise(t *testing.T) {
 				envMock.
 					On("Get", "SHELLHUB_CLOUD").
 					Return("false").
-					Once()
+					Twice()
 				envMock.
 					On("Get", "SHELLHUB_ENTERPRISE").
 					Return("false").
@@ -2469,7 +2469,7 @@ func TestUpdateDeviceStatus_community_and_enterprise(t *testing.T) {
 					Once()
 				envMock.
 					On("Get", "SHELLHUB_CLOUD").
-					Return("false").Once()
+					Return("false").Twice()
 				envMock.
 					On("Get", "SHELLHUB_ENTERPRISE").
 					Return("false").Once()