refactor(api): check if session exist before try to delete active session

Author: henrybarreto

api/services/session.go

@@ -4,7 +4,6 @@ import (
 	"context"
 	"net"
 
-	"github.com/shellhub-io/shellhub/api/store"
 	"github.com/shellhub-io/shellhub/pkg/api/query"
 	"github.com/shellhub-io/shellhub/pkg/api/requests"
 	"github.com/shellhub-io/shellhub/pkg/models"
@@ -51,12 +50,12 @@ func (s *service) CreateSession(ctx context.Context, session requests.SessionCre
 }
 
 func (s *service) DeactivateSession(ctx context.Context, uid models.UID) error {
-	err := s.store.SessionDeleteActives(ctx, uid)
-	if err == store.ErrNoDocuments {
+	sess, err := s.store.SessionGet(ctx, uid)
+	if err != nil {
 		return NewErrSessionNotFound(uid, err)
 	}
 
-	return err
+	return s.store.SessionDeleteActives(ctx, models.UID(sess.UID))
 }
 
 func (s *service) KeepAliveSession(ctx context.Context, uid models.UID) error {

api/services/session_test.go

@@ -231,25 +231,35 @@ func TestDeactivateSession(t *testing.T) {
 			name: "fails when session is not found",
 			uid:  models.UID("_uid"),
 			requiredMocks: func() {
-				mock.On("SessionDeleteActives", ctx, models.UID("_uid")).
-					Return(store.ErrNoDocuments).Once()
+				mock.On("SessionGet", ctx, models.UID("_uid")).
+					Return(nil, goerrors.New("get error")).Once()
 			},
-			expected: NewErrSessionNotFound("_uid", store.ErrNoDocuments),
+			expected: NewErrSessionNotFound("_uid", goerrors.New("get error")),
 		},
 		{
 			name: "fails",
 			uid:  models.UID("_uid"),
 			requiredMocks: func() {
+				mock.On("SessionGet", ctx, models.UID("_uid")).
+					Return(&models.Session{
+						UID: "_uid",
+					}, nil).Once()
+
 				mock.On("SessionDeleteActives", ctx, models.UID("_uid")).
 					Return(goerrors.New("error")).Once()
 			},
 			expected: goerrors.New("error"),
 		},
 		{
 			name: "succeeds",
-			uid:  models.UID("uid"),
+			uid:  models.UID("_uid"),
 			requiredMocks: func() {
-				mock.On("SessionDeleteActives", ctx, models.UID("uid")).
+				mock.On("SessionGet", ctx, models.UID("_uid")).
+					Return(&models.Session{
+						UID: "_uid",
+					}, nil).Once()
+
+				mock.On("SessionDeleteActives", ctx, models.UID("_uid")).
 					Return(nil).Once()
 			},
 			expected: nil,