fix(ui): validate key uniqueness in PrivateKeyEdit

Author: luizhf42

ui/src/components/PrivateKeys/PrivateKeyEdit.vue

@@ -285,9 +285,24 @@ const edit = async () => {
   } catch (error) {
     if ((error as Error).name === "KeyParseError") {
       setPassphraseError("Passphrase is not correct.");
-    } else {
-      snackbar.showError("Failed to update private key.");
-      handleError(error as Error);
+      return;
+    }
+
+    const errorMessage = (error as Error).message;
+    switch (errorMessage) {
+      case "both":
+        setNameError("Name is already used");
+        privateKeyDataError.value = "Private key data is already used";
+        break;
+      case "name":
+        setNameError("Name is already used");
+        break;
+      case "private_key":
+        privateKeyDataError.value = "Private key data is already used";
+        break;
+      default:
+        snackbar.showError("Failed to update private key.");
+        handleError(error as Error);
     }
   }
 };

ui/src/store/modules/private_keys.ts

@@ -9,27 +9,34 @@ const usePrivateKeysStore = defineStore("privateKey", () => {
     privateKeys.value = JSON.parse(localStorage.getItem("privateKeys") || "[]");
   };
 
-  const addPrivateKey = (newKey: Omit<IPrivateKey, "id">) => {
-    const existentIds: number[] = [];
+  const validateKeyUniqueness = (name: string, data: string, currentKeyId?: number) => {
+    // currentKeyId prevents validating against the key being edited
+    const hasSameName = privateKeys.value.some((key) => key.id !== currentKeyId && key.name === name);
+    const hasSameData = privateKeys.value.some((key) => key.id !== currentKeyId && key.data === data);
+
+    if (hasSameName && hasSameData) throw new Error("both");
+    if (hasSameData) throw new Error("private_key");
+    if (hasSameName) throw new Error("name");
+  };
 
-    privateKeys.value.forEach((key: IPrivateKey) => {
-      if (key.data === newKey.data && key.name === newKey.name) throw new Error("both");
-      if (key.data === newKey.data) throw new Error("private_key");
-      if (key.name === newKey.name) throw new Error("name");
-      existentIds.push(key.id);
-    });
+  const addPrivateKey = (newKey: Omit<IPrivateKey, "id">) => {
+    validateKeyUniqueness(newKey.name, newKey.data);
 
+    const existentIds = privateKeys.value.map((key) => key.id);
     const newKeyId = existentIds.length ? Math.max(...existentIds) + 1 : 1;
+
     privateKeys.value.push({ ...newKey, id: newKeyId });
     localStorage.setItem("privateKeys", JSON.stringify(privateKeys.value));
   };
 
   const editPrivateKey = (updatedKey: IPrivateKey) => {
     const index = privateKeys.value.findIndex((key) => key.id === updatedKey.id);
+    if (index === -1) throw new Error("Key not found");
+
     const existingKey = privateKeys.value[index];
 
-    if (existingKey && existingKey.data === updatedKey.data && existingKey.name === updatedKey.name) {
-      throw new Error();
+    if (existingKey.name !== updatedKey.name || existingKey.data !== updatedKey.data) {
+      validateKeyUniqueness(updatedKey.name, updatedKey.data, updatedKey.id);
     }
 
     privateKeys.value.splice(index, 1, updatedKey);

ui/tests/components/PrivateKeys/PrivateKeyEdit.spec.ts

@@ -95,6 +95,7 @@ describe("Private Key Edit", () => {
   });
 
   it("updates the store, emits 'update', and shows a success message on valid submission", async () => {
+    privateKeysStore.addPrivateKey(mockPrivateKey); // Ensure the key exists in the store
     const storeSpy = vi.spyOn(privateKeysStore, "editPrivateKey");
 
     await wrapper.find('[data-test="privatekey-edit-btn"]').trigger("click");

ui/tests/store/modules/private_keys.spec.ts

@@ -32,6 +32,8 @@ describe("PrivateKey Store", () => {
   });
 
   it("Edits a private key", () => {
+    const initialPrivateKey = { data: "data1", name: "name1", hasPassphrase: false, fingerprint: "fp1" };
+    privateKeysStore.addPrivateKey(initialPrivateKey);
     const privateKey = { id: 1, data: "data1-updated", name: "name1-updated", hasPassphrase: true, fingerprint: "fp1-updated" };
 
     privateKeysStore.editPrivateKey(privateKey);