Skip to content

Commit 841047f

Browse files
luizhf42gustavosbarreto
authored andcommitted
refactor(ui): use BaseDialog @close event in Terminal components
1 parent 6cfffee commit 841047f

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

ui/src/components/Terminal/TerminalDialog.vue

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,20 +2,19 @@
22
<BaseDialog
33
v-model="showDialog"
44
:forceFullscreen="!showLoginForm"
5-
@click:outside="close"
6-
@keydown.esc="close"
5+
@close="close"
76
>
87
<v-card data-test="terminal-card" class="bg-v-theme-surface">
98
<v-card-title
109
class="text-h5 pa-4 bg-primary d-flex align-center justify-space-between"
1110
>
1211
Terminal
13-
<v-icon v-if="!showLoginForm" @click="close()" data-test="close-terminal-btn" size="24">mdi-close</v-icon>
12+
<v-icon v-if="!showLoginForm" @click="close" data-test="close-terminal-btn" size="24">mdi-close</v-icon>
1413
</v-card-title>
1514

1615
<TerminalLoginForm
1716
v-if="showLoginForm"
18-
@submit="(params) => handleSubmit(params)"
17+
@submit="handleSubmit"
1918
@close="close"
2019
/>
2120
<Terminal

ui/src/components/Terminal/TerminalHelper.vue

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<template>
2-
<BaseDialog v-model="showDialog" @click:outside="clearData" transition="dialog-bottom-transition" data-test="dialog">
2+
<BaseDialog v-model="showDialog" @close="close" transition="dialog-bottom-transition" data-test="dialog">
33
<v-card class="bg-v-theme-surface">
44
<v-card-title class="text-h6 pa-4 bg-primary" data-test="dialog-title">
55
Generate a SSH command line
@@ -125,7 +125,7 @@ watch(showDialog, (isOpen) => {
125125
}
126126
});
127127
128-
const clearData = () => {
128+
const close = () => {
129129
username.value = "";
130130
showDialog.value = false;
131131
};

0 commit comments

Comments
 (0)