fix: apply morgan's law when adding member

henrybarreto · gustavosbarreto · commit a50824bc1052 · 2025-04-04T12:29:31.000-03:00
diff --git a/api/services/member.go b/api/services/member.go
@@ -93,7 +93,7 @@ func (s *service) AddNamespaceMember(ctx context.Context, req *requests.Namespac
 	if m, ok := namespace.FindMember(passiveUser.ID); ok {
 		now := clock.Now()
 
-		if !envs.IsCloud() || !(m.Status == models.MemberStatusPending && m.ExpiresAt.Before(now)) {
+		if !envs.IsCloud() || (m.Status != models.MemberStatusPending || !m.ExpiresAt.Before(now)) {
 			return nil, NewErrNamespaceMemberDuplicated(passiveUser.ID, nil)
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -93,7 +93,7 @@ func (s service) AddNamespaceMember(ctx context.Context, req requests.Namespac`
`93`	`93`	`if m, ok := namespace.FindMember(passiveUser.ID); ok {`
`94`	`94`	`now := clock.Now()`
`95`	`95`
`96`		`- if !envs.IsCloud() \|\| !(m.Status == models.MemberStatusPending && m.ExpiresAt.Before(now)) {`
	`96`	`+ if !envs.IsCloud() \|\| (m.Status != models.MemberStatusPending \|\| !m.ExpiresAt.Before(now)) {`
`97`	`97`	`return nil, NewErrNamespaceMemberDuplicated(passiveUser.ID, nil)`
`98`	`98`	`}`
`99`	`99`