Skip to content

Commit b956c1f

Browse files
luizhf42gustavosbarreto
authored andcommitted
fix(ui): rename Address field to Host in WebEndpointCreate
1 parent a02dbf0 commit b956c1f

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

ui/src/components/WebEndpoints/WebEndpointCreate.vue

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,17 +13,17 @@
1313
/>
1414
<v-card-text>
1515
<p class="mb-2" data-test="tunnel-create-text">
16-
Configure the address and port to create a tunnel to your device.
16+
Configure the host and port to create a tunnel to your device.
1717
</p>
1818
<v-row>
1919
<v-col sm="8" class="pb-0">
2020
<v-text-field
2121
v-model="host"
2222
class="mt-1"
23-
label="Address"
23+
label="Host"
2424
:error-messages="hostError"
2525
variant="underlined"
26-
data-test="address-text"
26+
data-test="host-text"
2727
/>
2828
</v-col>
2929
<p class="mt-7 pa-0"> : </p>

ui/tests/components/WebEndpoints/WebEndpointCreate.spec.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ describe("WebEndpointCreate.vue", () => {
4040

4141
expect(dialog.find('[data-test="tunnel-create-dialog"]').exists()).toBe(true);
4242
expect(dialog.find('[data-test="create-dialog-title"]').text()).toContain("Create Device Web Endpoint");
43-
expect(dialog.find('[data-test="address-text"]').exists()).toBe(true);
43+
expect(dialog.find('[data-test="host-text"]').exists()).toBe(true);
4444
expect(dialog.find('[data-test="port-text"]').exists()).toBe(true);
4545
expect(dialog.find('[data-test="timeout-combobox"]').exists()).toBe(true);
4646
expect(dialog.find('[data-test="custom-timeout"]').exists()).toBe(false);
@@ -52,7 +52,7 @@ describe("WebEndpointCreate.vue", () => {
5252

5353
const spy = vi.spyOn(store, "dispatch");
5454

55-
await wrapper.findComponent('[data-test="address-text"]').setValue("127.0.0.1");
55+
await wrapper.findComponent('[data-test="host-text"]').setValue("127.0.0.1");
5656
await wrapper.findComponent('[data-test="port-text"]').setValue("8080");
5757
await wrapper.findComponent('[data-test="create-tunnel-btn"]').trigger("click");
5858

@@ -71,7 +71,7 @@ describe("WebEndpointCreate.vue", () => {
7171

7272
const spy = vi.spyOn(store, "dispatch");
7373

74-
await wrapper.findComponent('[data-test="address-text"]').setValue("127.0.0.1");
74+
await wrapper.findComponent('[data-test="host-text"]').setValue("127.0.0.1");
7575
await wrapper.findComponent('[data-test="port-text"]').setValue("8080");
7676

7777
await wrapper.findComponent('[data-test="timeout-combobox"]').setValue(600);
@@ -90,7 +90,7 @@ describe("WebEndpointCreate.vue", () => {
9090
it("shows alert on 403 error", async () => {
9191
mockWebEndpoints.onPost("http://localhost:3000/api/web-endpoints").reply(403);
9292

93-
await wrapper.findComponent('[data-test="address-text"]').setValue("127.0.0.1");
93+
await wrapper.findComponent('[data-test="host-text"]').setValue("127.0.0.1");
9494
await wrapper.findComponent('[data-test="port-text"]').setValue("8080");
9595

9696
await wrapper.findComponent('[data-test="create-tunnel-btn"]').trigger("click");
@@ -129,7 +129,7 @@ describe("WebEndpointCreate.vue", () => {
129129
},
130130
});
131131

132-
await wrapper.findComponent('[data-test="address-text"]').setValue("127.0.0.1");
132+
await wrapper.findComponent('[data-test="host-text"]').setValue("127.0.0.1");
133133
await wrapper.findComponent('[data-test="port-text"]').setValue(8080);
134134

135135
await wrapper.findComponent('[data-test="create-tunnel-btn"]').trigger("click");

0 commit comments

Comments
 (0)