fix(gateway): avoid stopping renew loop when certbot command fails

henrybarreto · gustavosbarreto · commit bc9394e1149b · 2025-07-09T11:09:56.000-03:00
diff --git a/gateway/certbot.go b/gateway/certbot.go
@@ -216,8 +216,6 @@ func (cb *CertBot) executeRenewCertificates() error {
 	}
 
 	if err := cmd.Run(); err != nil {
-		log.WithError(err).Error("failed to renew SSL certificate")
-
 		return err
 	}
 
@@ -236,7 +234,9 @@ func (cb *CertBot) renewCertificates() {
 	for range ticker.C {
 		log.Info("checking if SSL certificate needs to be renewed")
 		if err := cb.executeRenewCertificates(); err != nil {
-			log.Fatal("failed to renew SSL certificate")
+			log.WithError(err).Error("failed to renew SSL certificate")
+
+			continue
 		}
 
 		log.Info("ssl certificate successfully renewed")

Original file line number	Diff line number	Diff line change
`@@ -216,8 +216,6 @@ func (cb *CertBot) executeRenewCertificates() error {`
`216`	`216`	`}`
`217`	`217`
`218`	`218`	`if err := cmd.Run(); err != nil {`
`219`		`- log.WithError(err).Error("failed to renew SSL certificate")`
`220`		`-`
`221`	`219`	`return err`
`222`	`220`	`}`
`223`	`221`
`@@ -236,7 +234,9 @@ func (cb *CertBot) renewCertificates() {`
`236`	`234`	`for range ticker.C {`
`237`	`235`	`log.Info("checking if SSL certificate needs to be renewed")`
`238`	`236`	`if err := cb.executeRenewCertificates(); err != nil {`
`239`		`- log.Fatal("failed to renew SSL certificate")`
	`237`	`+ log.WithError(err).Error("failed to renew SSL certificate")`
	`238`	`+`
	`239`	`+ continue`
`240`	`240`	`}`
`241`	`241`
`242`	`242`	`log.Info("ssl certificate successfully renewed")`