Skip to content

Commit c5680c2

Browse files
luizhf42gustavosbarreto
luizhf42
authored and
gustavosbarreto
committed
fix(ui): add v-form to FormDialog 
1 parent 30929d1 commit c5680c2

File tree

7 files changed

+710
-692
lines changed

7 files changed

+710
-692
lines changed

‎ui/src/components/FormDialog.vue‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,9 @@
1212
:show-footer="showFooter"
1313
>
1414
<!-- Content -->
15-
<slot />
15+
<v-form>
16+
<slot />
17+
</v-form>
1618

1719
<!-- Footer with form-specific functionality -->
1820
<template #footer>

‎ui/tests/components/Connectors/__snapshots__/ConnectorForm.spec.ts.snap‎

Lines changed: 182 additions & 178 deletions
Large diffs are not rendered by default.

‎ui/tests/components/Namespace/__snapshots__/NamespaceEdit.spec.ts.snap‎

Lines changed: 40 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -56,53 +56,55 @@ exports[`Namespace Edit > Renders the component 1`] = `
5656
<!---->
5757
</transition-stub>
5858
</header><!-- Content -->
59-
<div class="v-card-text pa-6">
60-
<div class="v-input v-input--horizontal v-input--density-default v-theme--light v-locale--is-ltr v-textarea v-text-field v-textarea--auto-grow v-textarea--no-resize" data-test="connection-announcement-text">
61-
<!---->
62-
<div class="v-input__control">
63-
<div class="v-field v-field--variant-filled v-theme--light v-locale--is-ltr" style="--v-textarea-control-height: NaN;">
64-
<div class="v-field__overlay"></div>
65-
<div class="v-field__loader">
66-
<div class="v-progress-linear v-theme--light v-locale--is-ltr" style="top: 0px; height: 0px; --v-progress-linear-height: 2px;" role="progressbar" aria-hidden="true" aria-valuemin="0" aria-valuemax="100">
67-
<!---->
68-
<div class="v-progress-linear__background"></div>
69-
<div class="v-progress-linear__buffer" style="width: 0%;"></div>
70-
<transition-stub name="fade-transition" appear="false" persisted="false" css="true">
71-
<div class="v-progress-linear__indeterminate">
72-
<div class="v-progress-linear__indeterminate long"></div>
73-
<div class="v-progress-linear__indeterminate short"></div>
74-
</div>
75-
</transition-stub>
76-
<!---->
59+
<form class="v-form" novalidate="">
60+
<div class="v-card-text pa-6">
61+
<div class="v-input v-input--horizontal v-input--density-default v-theme--light v-locale--is-ltr v-textarea v-text-field v-textarea--auto-grow v-textarea--no-resize" data-test="connection-announcement-text">
62+
<!---->
63+
<div class="v-input__control">
64+
<div class="v-field v-field--variant-filled v-theme--light v-locale--is-ltr" style="--v-textarea-control-height: NaN;">
65+
<div class="v-field__overlay"></div>
66+
<div class="v-field__loader">
67+
<div class="v-progress-linear v-theme--light v-locale--is-ltr" style="top: 0px; height: 0px; --v-progress-linear-height: 2px;" role="progressbar" aria-hidden="true" aria-valuemin="0" aria-valuemax="100">
68+
<!---->
69+
<div class="v-progress-linear__background"></div>
70+
<div class="v-progress-linear__buffer" style="width: 0%;"></div>
71+
<transition-stub name="fade-transition" appear="false" persisted="false" css="true">
72+
<div class="v-progress-linear__indeterminate">
73+
<div class="v-progress-linear__indeterminate long"></div>
74+
<div class="v-progress-linear__indeterminate short"></div>
75+
</div>
76+
</transition-stub>
77+
<!---->
78+
</div>
7779
</div>
78-
</div>
79-
<!---->
80-
<div class="v-field__field" data-no-activator=""><label class="v-label v-field-label v-field-label--floating" for="input-v-2" aria-hidden="true">
81-
<!---->Connection Announcement
82-
</label><label class="v-label v-field-label" for="input-v-2">
83-
<!---->Connection Announcement
84-
</label>
85-
<!----><textarea class="v-field__input" rows="5" id="input-v-2" aria-describedby="input-v-2-messages" required="" value=""></textarea><textarea class="v-field__input v-textarea__sizer" id="input-v-2-sizer" readonly="" aria-hidden="true"></textarea>
8680
<!---->
87-
</div>
88-
<!---->
89-
<!---->
90-
<div class="v-field__outline">
81+
<div class="v-field__field" data-no-activator=""><label class="v-label v-field-label v-field-label--floating" for="input-v-2" aria-hidden="true">
82+
<!---->Connection Announcement
83+
</label><label class="v-label v-field-label" for="input-v-2">
84+
<!---->Connection Announcement
85+
</label>
86+
<!----><textarea class="v-field__input" rows="5" id="input-v-2" aria-describedby="input-v-2-messages" required="" value=""></textarea><textarea class="v-field__input v-textarea__sizer" id="input-v-2-sizer" readonly="" aria-hidden="true"></textarea>
87+
<!---->
88+
</div>
9189
<!---->
9290
<!---->
91+
<div class="v-field__outline">
92+
<!---->
93+
<!---->
94+
</div>
9395
</div>
9496
</div>
95-
</div>
96-
<!---->
97-
<div id="input-v-2-messages" class="v-input__details" role="alert" aria-live="polite">
98-
<transition-group-stub name="slide-y-transition" tag="div" appear="false" persisted="false" css="true" class="v-messages">
99-
<div class="v-messages__message">A connection announcement is a custom message written during a session
100-
when a connection is established on a device within the namespace.</div>
101-
</transition-group-stub>
10297
<!---->
98+
<div id="input-v-2-messages" class="v-input__details" role="alert" aria-live="polite">
99+
<transition-group-stub name="slide-y-transition" tag="div" appear="false" persisted="false" css="true" class="v-messages">
100+
<div class="v-messages__message">A connection announcement is a custom message written during a session
101+
when a connection is established on a device within the namespace.</div>
102+
</transition-group-stub>
103+
<!---->
104+
</div>
103105
</div>
104106
</div>
105-
</div><!-- Footer -->
107+
</form><!-- Footer -->
106108
<header class="v-toolbar v-toolbar--density-default bg-primary v-theme--light v-locale--is-ltr bg-v-theme-surface border-t px-6 py-2">
107109
<!---->
108110
<div class="v-toolbar__content" style="height: 64px;">

‎ui/tests/components/Team/Member/__snapshots__/MemberEdit.spec.ts.snap‎

Lines changed: 40 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -56,55 +56,57 @@ exports[`Member Edit > Renders the component 1`] = `
5656
<!---->
5757
</transition-stub>
5858
</header><!-- Content -->
59-
<div class="v-card-text pa-6">
60-
<div data-v-444f7389="" class="v-input v-input--horizontal v-input--center-affix v-input--density-default v-theme--light v-locale--is-ltr v-input--dirty v-text-field v-select v-select--single v-select--selected" data-test="role-select">
61-
<!---->
62-
<div class="v-input__control">
63-
<div class="v-field v-field--active v-field--appended v-field--center-affix v-field--dirty v-field--variant-filled v-theme--light v-locale--is-ltr" role="combobox" aria-haspopup="listbox" aria-expanded="false" aria-controls="menu-v-1">
64-
<div class="v-field__overlay"></div>
65-
<div class="v-field__loader">
66-
<div class="v-progress-linear v-theme--light v-locale--is-ltr" style="top: 0px; height: 0px; --v-progress-linear-height: 2px;" role="progressbar" aria-hidden="true" aria-valuemin="0" aria-valuemax="100">
59+
<form class="v-form" novalidate="">
60+
<div class="v-card-text pa-6">
61+
<div data-v-444f7389="" class="v-input v-input--horizontal v-input--center-affix v-input--density-default v-theme--light v-locale--is-ltr v-input--dirty v-text-field v-select v-select--single v-select--selected" data-test="role-select">
62+
<!---->
63+
<div class="v-input__control">
64+
<div class="v-field v-field--active v-field--appended v-field--center-affix v-field--dirty v-field--variant-filled v-theme--light v-locale--is-ltr" role="combobox" aria-haspopup="listbox" aria-expanded="false" aria-controls="menu-v-1">
65+
<div class="v-field__overlay"></div>
66+
<div class="v-field__loader">
67+
<div class="v-progress-linear v-theme--light v-locale--is-ltr" style="top: 0px; height: 0px; --v-progress-linear-height: 2px;" role="progressbar" aria-hidden="true" aria-valuemin="0" aria-valuemax="100">
68+
<!---->
69+
<div class="v-progress-linear__background"></div>
70+
<div class="v-progress-linear__buffer" style="width: 0%;"></div>
71+
<transition-stub name="fade-transition" appear="false" persisted="false" css="true">
72+
<div class="v-progress-linear__indeterminate">
73+
<div class="v-progress-linear__indeterminate long"></div>
74+
<div class="v-progress-linear__indeterminate short"></div>
75+
</div>
76+
</transition-stub>
77+
<!---->
78+
</div>
79+
</div>
80+
<!---->
81+
<div class="v-field__field" data-no-activator=""><label class="v-label v-field-label v-field-label--floating" for="input-v-3" aria-hidden="false">
82+
<!---->Role
83+
</label><label class="v-label v-field-label" for="input-v-3">
84+
<!---->Role
85+
</label>
6786
<!---->
68-
<div class="v-progress-linear__background"></div>
69-
<div class="v-progress-linear__buffer" style="width: 0%;"></div>
70-
<transition-stub name="fade-transition" appear="false" persisted="false" css="true">
71-
<div class="v-progress-linear__indeterminate">
72-
<div class="v-progress-linear__indeterminate long"></div>
73-
<div class="v-progress-linear__indeterminate short"></div>
74-
</div>
75-
</transition-stub>
87+
<div class="v-field__input" data-no-activator="">
88+
<!---->
89+
<!---->
90+
<div class="v-select__selection"><span class="v-select__selection-text">owner<!----></span></div><input size="1" role="combobox" type="text" id="input-v-3" inputmode="none" aria-expanded="false" aria-controls="menu-v-1" aria-label="Open" title="Open" required="" value="owner">
91+
</div>
7692
<!---->
7793
</div>
78-
</div>
79-
<!---->
80-
<div class="v-field__field" data-no-activator=""><label class="v-label v-field-label v-field-label--floating" for="input-v-3" aria-hidden="false">
81-
<!---->Role
82-
</label><label class="v-label v-field-label" for="input-v-3">
83-
<!---->Role
84-
</label>
8594
<!---->
86-
<div class="v-field__input" data-no-activator="">
95+
<div class="v-field__append-inner">
96+
<!----><i class="mdi-menu-down mdi v-icon notranslate v-theme--light v-icon--size-default v-select__menu-icon" aria-hidden="true"></i>
97+
<!---->
98+
</div>
99+
<div class="v-field__outline">
87100
<!---->
88101
<!---->
89-
<div class="v-select__selection"><span class="v-select__selection-text">owner<!----></span></div><input size="1" role="combobox" type="text" id="input-v-3" inputmode="none" aria-expanded="false" aria-controls="menu-v-1" aria-label="Open" title="Open" required="" value="owner">
90102
</div>
91-
<!---->
92-
</div>
93-
<!---->
94-
<div class="v-field__append-inner">
95-
<!----><i class="mdi-menu-down mdi v-icon notranslate v-theme--light v-icon--size-default v-select__menu-icon" aria-hidden="true"></i>
96-
<!---->
97-
</div>
98-
<div class="v-field__outline">
99-
<!---->
100-
<!---->
101103
</div>
102104
</div>
105+
<!---->
106+
<!---->
103107
</div>
104-
<!---->
105-
<!---->
106108
</div>
107-
</div><!-- Footer -->
109+
</form><!-- Footer -->
108110
<header class="v-toolbar v-toolbar--density-default bg-primary v-theme--light v-locale--is-ltr bg-v-theme-surface border-t px-6 py-2">
109111
<!---->
110112
<div class="v-toolbar__content" style="height: 64px;">

0 commit comments

Comments
 (0)