fix(jsx-email): remove react/jsx-runtime from jsx-email bundle (#282)

lordelogos · shellscape · web-flow · commit abf7ec146c2e · 2025-01-17T17:03:23.000-05:00
Co-authored-by: Andrew Powell &lt;shellscape@users.noreply.github.com&gt;
diff --git a/packages/jsx-email/package.json b/packages/jsx-email/package.json
@@ -106,7 +106,7 @@
     "postcss": "^8.4.32",
     "postcss-var-replace": "^1.0.0",
     "pretty-bytes": "^6.1.1",
-    "react-dom": "^18.2.0",
+    "react-dom": "^19",
     "react-router-dom": "7.0.1",
     "rehype": "^13.0.1",
     "rehype-stringify": "^10.0.0",
diff --git a/packages/jsx-email/src/cli/commands/preview.mts b/packages/jsx-email/src/cli/commands/preview.mts
@@ -68,6 +68,7 @@ const buildDeployable = async ({ argv, targetPath }: PreviewCommonParams) => {
       minify: false,
       outDir: buildPath,
       rollupOptions: {
+        external: ['react/jsx-runtime'],
         output: {
           manualChunks: {}
         }

Original file line number	Diff line number	Diff line change
`@@ -68,6 +68,7 @@ const buildDeployable = async ({ argv, targetPath }: PreviewCommonParams) => {`
`68`	`68`	`minify: false,`
`69`	`69`	`outDir: buildPath,`
`70`	`70`	`rollupOptions: {`
	`71`	`+ external: ['react/jsx-runtime'],`
`71`	`72`	`output: {`
`72`	`73`	`manualChunks: {}`
`73`	`74`	`}`