Skip to content

Commit 0fbadbb

Browse files
committed
fix: pass compiler to middleware
1 parent e5692ee commit 0fbadbb

File tree

3 files changed

+19
-188
lines changed

3 files changed

+19
-188
lines changed

README.md

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -49,9 +49,12 @@ const middleware = require('koa-webpack');
4949

5050
const app = new Koa();
5151

52-
app.use(middleware({
53-
// options
54-
}))
52+
const koaWebpack = require('koa-webpack');
53+
54+
koaWebpack({ .. options .. })
55+
.then((middleware) => {
56+
app.use(middleware);
57+
});
5558
```
5659

5760
## API
@@ -84,14 +87,15 @@ this option.
8487
Example:
8588

8689
```js
87-
import Webpack from 'webpack';
88-
import config from './webpack.config.js';
89-
90+
const webpack = require('webpack');
91+
const config = require('./webpack.config.js');
9092
const compiler = Webpack(config);
93+
const koaWebpack = require('koa-webpack');
9194

92-
app.use(middleware({
93-
compiler: compiler
94-
}))
95+
koaWebpack({ compiler })
96+
.then((middleware) => {
97+
app.use(middleware);
98+
});
9599
```
96100

97101
### config

README.old.md

Lines changed: 0 additions & 171 deletions
This file was deleted.

lib/index.js

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -34,21 +34,19 @@ const getClient = (compiler, options) => {
3434
});
3535
};
3636

37-
const getMiddleware = (devWare, options) => (context, next) =>
37+
const getMiddleware = (compiler, devWare) => (context, next) =>
3838
// wait for webpack-dev-middleware to signal that the build is ready
3939
Promise.all([
4040
new Promise((resolve, reject) => {
41-
const { compiler } = options;
42-
43-
devWare.waitUntilValid(() => {
44-
resolve(true);
45-
});
46-
4741
for (const comp of [].concat(compiler.compilers || compiler)) {
4842
comp.hooks.failed.tap('KoaWebpack', (error) => {
4943
reject(error);
5044
});
5145
}
46+
47+
devWare.waitUntilValid(() => {
48+
resolve(true);
49+
});
5250
}),
5351

5452
// tell webpack-dev-middleware to handle the request
@@ -99,7 +97,7 @@ module.exports = (opts) => {
9997

10098
return getClient(compiler, options).then((client) => {
10199
const devWare = devMiddleware(compiler, options.devMiddleware);
102-
const middleware = getMiddleware(devWare, options);
100+
const middleware = getMiddleware(compiler, devWare);
103101
const close = (callback) => {
104102
const next = client ? () => client.close(callback) : callback;
105103
devWare.close(next);

0 commit comments

Comments
 (0)