fix: hexadecimal notation with 4 characters (#44)

evilebottnawi · shellscape · commit 1a09208347e9 · 2018-02-12T11:59:36.000-05:00
diff --git a/lib/parser.js b/lib/parser.js
@@ -463,7 +463,7 @@ module.exports = class Parser {
 
         if (node.constructor.name === 'Word') {
           node.isHex = /^#(.+)/.test(value);
-          node.isColor = /^#([0-9a-f]{3}|[0-9a-f]{6}|[0-9a-f]{8})$/i.test(value);
+          node.isColor = /^#([0-9a-f]{3}|[0-9a-f]{4}|[0-9a-f]{6}|[0-9a-f]{8})$/i.test(value);
         }
         else {
           this.cache.push(this.current);
diff --git a/test/word.js b/test/word.js
@@ -70,9 +70,10 @@ describe('Parser → Word', () => {
     },
     {
       it: 'should parse hex colors',
-      test: '#123 #abcdef #a2b3c4d5',
+      test: '#123 #f09f #abcdef #a2b3c4d5',
       expected: [
         { type: 'word', value: '#123', isHex: true, isColor: true },
+        { type: 'word', value: '#f09f', isHex: true, isColor: true },
         { type: 'word', value: '#abcdef', isHex: true, isColor: true },
         { type: 'word', value: '#a2b3c4d5', isHex: true, isColor: true  }
       ]

Original file line number	Diff line number	Diff line change
`@@ -463,7 +463,7 @@ module.exports = class Parser {`
`463`	`463`
`464`	`464`	`if (node.constructor.name === 'Word') {`
`465`	`465`	`node.isHex = /^#(.+)/.test(value);`
`466`		`- node.isColor = /^#([0-9a-f]{3}\|[0-9a-f]{6}\|[0-9a-f]{8})$/i.test(value);`
	`466`	`+ node.isColor = /^#([0-9a-f]{3}\|[0-9a-f]{4}\|[0-9a-f]{6}\|[0-9a-f]{8})$/i.test(value);`
`467`	`467`	`}`
`468`	`468`	`else {`
`469`	`469`	`this.cache.push(this.current);`
Original file line number	Diff line number	Diff line change
`@@ -70,9 +70,10 @@ describe('Parser → Word', () => {`
`70`	`70`	`},`
`71`	`71`	`{`
`72`	`72`	`it: 'should parse hex colors',`
`73`		`- test: '#123 #abcdef #a2b3c4d5',`
	`73`	`+ test: '#123 #f09f #abcdef #a2b3c4d5',`
`74`	`74`	`expected: [`
`75`	`75`	`{ type: 'word', value: '#123', isHex: true, isColor: true },`
	`76`	`+ { type: 'word', value: '#f09f', isHex: true, isColor: true },`
`76`	`77`	`{ type: 'word', value: '#abcdef', isHex: true, isColor: true },`
`77`	`78`	`{ type: 'word', value: '#a2b3c4d5', isHex: true, isColor: true }`
`78`	`79`	`]`