refactor: use parse instead of preprocess

Author: shellscape

assets/banner.ai

@@ -14,30 +14,33 @@ const { scripts } = require('./scripts');
 const { sort } = require('./sort');
 
 const { 'json-stringify': parser } = parsers;
+const { parse } = parser;
 const rePkg = /package\.json$/;
 
-const format = (input) => {
-  let pkg = JSON.parse(input);
-  pkg = sort(pkg);
-  pkg = scripts(pkg);
+const format = (properties) => {
+  let props = sort(properties);
+  props = scripts(props);
 
-  const result = JSON.stringify(pkg, null, 2);
-  return result;
+  return props;
 };
 
-exports.parsers = {
-  'json-stringify': {
-    ...parser,
-    preprocess(input, options) {
-      const { filepath } = options;
-      const text = parser.preprocess ? parser.preprocess(input, options) : input;
-
-      if (rePkg.test(filepath)) {
-        const result = format(text);
-        return result;
+module.exports = {
+  name: 'prettier-plugin-package',
+  parsers: {
+    'json-stringify': {
+      ...parser,
+      parse(...args) {
+        const [, , options] = args;
+        const { filepath } = options;
+        const ast = parse(...args);
+
+        if (rePkg.test(filepath)) {
+          const { properties } = ast;
+          ast.properties = format(properties);
+        }
+
+        return ast;
       }
-
-      return text;
     }
   }
 };

lib/index.js

@@ -8,23 +8,19 @@
   The above copyright notice and this permission notice shall be
   included in all copies or substantial portions of this Source Code Form.
 */
-const sortScripts = (pkg) => {
-  const { scripts } = pkg;
+const sort = (props) => {
+  const scriptsIndex = props.findIndex((prop) => prop.key.value === 'scripts');
 
-  if (!scripts) {
-    return pkg;
+  if (scriptsIndex) {
+    const scripts = props[scriptsIndex];
+    scripts.value.properties.sort((a, b) =>
+      a.key.value > b.key.value ? 1 : a.key.value < b.key.value ? -1 : 0
+    );
+    // eslint-disable-next-line no-param-reassign
+    props[scriptsIndex] = scripts;
   }
 
-  const result = Object.assign({}, pkg, { scripts: {} });
-  const keys = Object.keys(scripts).sort();
-
-  for (const key of keys) {
-    if (scripts[key]) {
-      result.scripts[key] = scripts[key];
-    }
-  }
-
-  return result;
+  return props;
 };
 
-module.exports = { scripts: sortScripts };
+module.exports = { scripts: sort };

lib/scripts.js

@@ -45,19 +45,25 @@ const primary = [
   'resolutions'
 ];
 
-const sort = (pkg) => {
-  const result = {};
-  const unknown = Object.keys(pkg)
-    .filter((key) => !primary.includes(key))
-    .sort();
-
-  for (const key of primary.concat(unknown)) {
-    if (pkg[key]) {
-      result[key] = pkg[key];
+const sort = (props) => {
+  const unknown = [];
+  const known = props.filter((prop) => {
+    if (primary.includes(prop.key.value)) {
+      return true;
     }
-  }
+    unknown.push(prop);
+    return false;
+  });
 
-  return result;
+  known.sort((a, b) => {
+    const aIndex = primary.indexOf(a.key.value);
+    const bIndex = primary.indexOf(b.key.value);
+
+    return aIndex > bIndex ? 1 : aIndex < bIndex ? -1 : 0;
+  });
+  unknown.sort((a, b) => (a.key.value > b.key.value ? 1 : a.key.value < b.key.value ? -1 : 0));
+
+  return known.concat(unknown);
 };
 
 module.exports = { sort };

lib/sort.js

@@ -0,0 +1,4 @@
+{
+  "name": "prettier-plugin-package",
+  "batmam": {]
+}

test/fixtures/broken.json

@@ -1,10 +1,11 @@
+const { readFileSync } = require('fs');
 const { join } = require('path');
 
 const test = require('ava');
 const prettier = require('prettier');
 
 const pkg = require('./fixtures/fixture.json');
-
+//
 const shuffle = (arr) => {
   const result = arr.slice();
   for (let i = result.length - 1; i > 0; i--) {
@@ -70,3 +71,16 @@ test('not package.json', (t) => {
 
   t.is(input.trim(), output.trim());
 });
+
+test('broken json', (t) => {
+  const options = {
+    filepath: 'broken.json',
+    parser: 'json-stringify',
+    plugins: ['.']
+  };
+
+  const broken = readFileSync(join(__dirname, './fixtures/broken.json'), 'utf-8');
+  const fail = () => prettier.format(broken, options);
+
+  t.throws(fail);
+});