Skip to content

Commit 94c0138

Browse files
committed
fix(sites): Remove BoardGameGeek due to incompatible detection
BoardGameGeek cannot be reliably detected with Sherlock's current capabilities: - Original HTML detection: Returns false positives - API endpoint approach: The API returns status 200 for both valid and invalid users - Invalid user: Returns exactly '[]' - Valid user: Returns JSON containing '[]' substrings (e.g., "adminBadges":[]) Since Sherlock's 'message' errorType uses substring matching, it incorrectly identifies valid users as "not found" when checking for '[]' in the response. The site's API response format is fundamentally incompatible with Sherlock's detection methods (message/status_code/response_url), so removal is the only viable solution to prevent false positives and false negatives. Addresses false positive issue originally reported in testing.
1 parent c5e209d commit 94c0138

File tree

1 file changed

+0
-9
lines changed

1 file changed

+0
-9
lines changed

sherlock_project/resources/data.json

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -278,15 +278,6 @@
278278
"urlMain": "https://bsky.app/",
279279
"username_claimed": "mcuban"
280280
},
281-
"BoardGameGeek": {
282-
"errorMsg": "[]",
283-
"errorType": "message",
284-
"regexCheck": "^[a-zA-Z0-9_]*$",
285-
"url": "https://boardgamegeek.com/profile/{}",
286-
"urlMain": "https://boardgamegeek.com",
287-
"urlProbe": "https://api.geekdo.com/api/users?username={}",
288-
"username_claimed": "blue"
289-
},
290281
"BongaCams": {
291282
"errorType": "status_code",
292283
"isNSFW": true,

0 commit comments

Comments
 (0)