Skip to content

Conversation

Fandroid745
Copy link

@Fandroid745 Fandroid745 commented Oct 5, 2025

Regarding issue #2161. This pr fixes the false positive detection for the site BabyRu (https://www.baby.ru/)

Edit: (@ppfeister)
Fixes: #2161 (not used in original desc, not auto-linked)
username_claimed is set to an empty string because BabyRu usernames cannot be reliably accessed due to regional restrictions and rate limiting.

Copy link
Contributor

github-actions bot commented Oct 5, 2025

Failed to generate summary of test results

Copy link
Contributor

github-actions bot commented Oct 5, 2025

Automatic validation of changes

Target F+ Check F- Check
BoardGameGeek ❌   Fail ✔️   Pass
BabyRu ❌   Fail ❌   Fail

Failures were detected on at least one updated target. Commits containing accuracy failures will often not be merged (unless a rationale is provided, such as false negatives due to regional differences).

@ppfeister
Copy link
Member

Unsure if you're using an IDE or a text editor, but an IDE such as VSCode should automatically understand the linked json schema and flag errors (it should also suggest required fields)

Copy link
Contributor

github-actions bot commented Oct 5, 2025

Automatic validation of changes

Target F+ Check F- Check
BabyRu ❌   Fail ❌   Fail

Failures were detected on at least one updated target. Commits containing accuracy failures will often not be merged (unless a rationale is provided, such as false negatives due to regional differences).

Copy link
Contributor

github-actions bot commented Oct 6, 2025

Automatic validation of changes

Target F+ Check F- Check
BabyRu ✔️   Pass ❌   Fail

Failures were detected on at least one updated target. Commits containing accuracy failures will often not be merged (unless a rationale is provided, such as false negatives due to regional differences).

@Fandroid745

This comment was marked as spam.

@ppfeister
Copy link
Member

It's been one day. Please be patient.

  • regexCheck should be absent when empty
  • Returning false negatives without rationale (as indicated in the automated reply -- if this is due to regional differences, this is often acceptable, but a satisfactory result should be shared in-thread to confirm)
  • Tests fail on Windows (russian script likely needs to be encoded)
  • Indentation on the closing brace, while json compliant, is poor practice and will be easily accidentally removed when perceived as a duplicated closure of the greater object.

Copy link
Contributor

github-actions bot commented Oct 7, 2025

Automatic validation of changes

Target F+ Check F- Check
BabyRu ✔️   Pass ❌   Fail

Failures were detected on at least one updated target. Commits containing accuracy failures will often not be merged (unless a rationale is provided, such as false negatives due to regional differences).

Copy link
Contributor

github-actions bot commented Oct 7, 2025

Automatic validation of changes

Target F+ Check F- Check
BabyRu ✔️   Pass ❌   Fail

Failures were detected on at least one updated target. Commits containing accuracy failures will often not be merged (unless a rationale is provided, such as false negatives due to regional differences).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive for: babyRU
2 participants