-
-
Notifications
You must be signed in to change notification settings - Fork 8.1k
fix: Add error messages to BabyRu to prevent false positives #2606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix: Add error messages to BabyRu to prevent false positives #2606
Conversation
Failed to generate summary of test results |
Automatic validation of changes
Failures were detected on at least one updated target. Commits containing accuracy failures will often not be merged (unless a rationale is provided, such as false negatives due to regional differences). |
Unsure if you're using an IDE or a text editor, but an IDE such as VSCode should automatically understand the linked json schema and flag errors (it should also suggest required fields) |
Automatic validation of changes
Failures were detected on at least one updated target. Commits containing accuracy failures will often not be merged (unless a rationale is provided, such as false negatives due to regional differences). |
Automatic validation of changes
Failures were detected on at least one updated target. Commits containing accuracy failures will often not be merged (unless a rationale is provided, such as false negatives due to regional differences). |
This comment was marked as spam.
This comment was marked as spam.
It's been one day. Please be patient.
|
Automatic validation of changes
Failures were detected on at least one updated target. Commits containing accuracy failures will often not be merged (unless a rationale is provided, such as false negatives due to regional differences). |
Automatic validation of changes
Failures were detected on at least one updated target. Commits containing accuracy failures will often not be merged (unless a rationale is provided, such as false negatives due to regional differences). |
Regarding issue #2161. This pr fixes the false positive detection for the site BabyRu (https://www.baby.ru/)
Edit: (@ppfeister)
Fixes: #2161 (not used in original desc, not auto-linked)
username_claimed is set to an empty string because BabyRu usernames cannot be reliably accessed due to regional restrictions and rate limiting.