Skip to content

Conversation

eslteacher902010
Copy link

Added MuseScore support to data.json.
Validated JSON locally (python3 -m json.tool) — no syntax errors.
MuseScore pages return dynamic content, so username detection may currently return zero results, but the structure is correct and ready for future improvements.

This is a clean version of the earlier PR (#2600), created directly from master with no test HTML files or unintended PayPal changes.

Copy link
Contributor

github-actions bot commented Oct 5, 2025

Automatic validation of changes

Target F+ Check F- Check
BoardGameGeek ❌   Fail ✔️   Pass
MuseScore ✔️   Pass ❌   Fail

Failures were detected on at least one updated target. Commits containing accuracy failures will often not be merged (unless a rationale is provided, such as false negatives due to regional differences).

@akh7177
Copy link
Contributor

akh7177 commented Oct 5, 2025

Hello @eslteacher902010 ,

When checked against the claimed username mentioned in the commit (https://musescore.com/musescore), I end up at 404 Page not found. Could you please check where the issue lies, the endpoint or the claimed username? It might also be a region related issue. Kindly have a look and lemme know!

(Thanks for cleaning up the PR)

Copy link
Contributor

github-actions bot commented Oct 5, 2025

Automatic validation of changes

Target F+ Check F- Check
MuseScore ✔️   Pass ❌   Fail
BoardGameGeek ❌   Fail ✔️   Pass

Failures were detected on at least one updated target. Commits containing accuracy failures will often not be merged (unless a rationale is provided, such as false negatives due to regional differences).

@eslteacher902010
Copy link
Author

@akh7177 Thanks! I switched the username to arrangeme, which resolves correctly in the browser. It seems MuseScore returns 403 for automated requests, so that might explain the difference.

@akh7177
Copy link
Contributor

akh7177 commented Oct 5, 2025

@akh7177 Thanks! I switched the username to arrangeme, which resolves correctly in the browser. It seems MuseScore returns 403 for automated requests, so that might explain the difference.

Even https://musescore.com/user/arrangeme hits me with Page Not Found. Is it not the case for you?

Copy link
Contributor

github-actions bot commented Oct 5, 2025

Automatic validation of changes

Target F+ Check F- Check
MuseScore ✔️   Pass ❌   Fail
BoardGameGeek ❌   Fail ✔️   Pass

Failures were detected on at least one updated target. Commits containing accuracy failures will often not be merged (unless a rationale is provided, such as false negatives due to regional differences).

@eslteacher902010
Copy link
Author

You’re right — sorry about that! I shouldn’t have included /user/ in the path. I’ve updated it to https://musescore.com/{} since https://musescore.com/arrangeme resolves correctly now.

@akh7177
Copy link
Contributor

akh7177 commented Oct 6, 2025

You’re right — sorry about that! I shouldn’t have included /user/ in the path. I’ve updated it to https://musescore.com/{} since https://musescore.com/arrangeme resolves correctly now.

Great! Setting error type as status code seems to be giving a 403 response code for all usernames but changing it to message and setting error_msg to "<title>Page not found (404) | MuseScore.com</title>" seems to work. Not sure as to why this is happening. Any idea @ppfeister?

@ppfeister
Copy link
Member

ppfeister commented Oct 6, 2025

@akh7177

Is the 404 page actually returning a 404 status code, or a 200 that says 404 to the user?

If the actual status codes are in fact different, it's likely a request method issue.

status_code defaults to HEAD whereas message defaults to GET. You can use status_code with GET however via the requestMethod attribute.

(not at my desk, so the attribute names may be slightly off)

@akh7177
Copy link
Contributor

akh7177 commented Oct 6, 2025

@akh7177

Is the 404 page actually returning a 404 status code, or a 200 that says 404 to the user?

If the actual status codes are in fact different, it's likely a request method issue.

status_code defaults to HEAD whereas message defaults to GET. You can use status_code with GET however via the requestMethod attribute.

(not at my desk, so the attribute names may be slightly off)

When I load https://musescore.com/choldgraf on browser, it gives a status code of 404. But upon executing sherlock choldgraf --site 'MuseScore' -l --dump-response the response code is 403.

+++++++++++++++++++++
TARGET NAME : MuseScore
USERNAME : choldgraf
TARGET URL : https://musescore.com/choldgraf
TEST METHOD : status_code
Results...
RESPONSE CODE : 403

BEGIN RESPONSE TEXT

<<<<< END RESPONSE TEXT
VERDICT : Available
+++++++++++++++++++++

[*] Search completed with 0 results

Looks like I need to use status_code with GET

@eslteacher902010
Copy link
Author

Thanks @akh7177 and @ppfeister. I confirmed locally that MuseScore returns a 403 for HEAD requests but works correctly with GET. I added "request_method": "GET" under "errorType": "status_code" and verified the following:

arrangeme → Found (200)

thisuserdoesnotexist999 → Not Found (404)

This resolves the 403 issue on my end, though I haven’t seen other sites using a request_method field yet.

@akh7177
Copy link
Contributor

akh7177 commented Oct 6, 2025

Thanks @akh7177 and @ppfeister. I confirmed locally that MuseScore returns a 403 for HEAD requests but works correctly with GET. I added "request_method": "GET" under "errorType": "status_code" and verified the following:

arrangeme → Found (200)

thisuserdoesnotexist999 → Not Found (404)

This resolves the 403 issue on my end, though I haven’t seen other sites using a request_method field yet.

Cool! Could you also modify that in this PR?

Copy link
Contributor

github-actions bot commented Oct 6, 2025

Automatic validation of changes

Target F+ Check F- Check
MuseScore ✔️   Pass ✔️   Pass

@eslteacher902010
Copy link
Author

Thanks! Just pushed the update with "request_method": "GET" for MuseScore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants