-
-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Add MuseScore site (clean version) #2610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add MuseScore site (clean version) #2610
Conversation
Automatic validation of changes
Failures were detected on at least one updated target. Commits containing accuracy failures will often not be merged (unless a rationale is provided, such as false negatives due to regional differences). |
Hello @eslteacher902010 , When checked against the claimed username mentioned in the commit (https://musescore.com/musescore), I end up at 404 Page not found. Could you please check where the issue lies, the endpoint or the claimed username? It might also be a region related issue. Kindly have a look and lemme know! (Thanks for cleaning up the PR) |
Automatic validation of changes
Failures were detected on at least one updated target. Commits containing accuracy failures will often not be merged (unless a rationale is provided, such as false negatives due to regional differences). |
@akh7177 Thanks! I switched the username to arrangeme, which resolves correctly in the browser. It seems MuseScore returns 403 for automated requests, so that might explain the difference. |
Even https://musescore.com/user/arrangeme hits me with Page Not Found. Is it not the case for you? |
Automatic validation of changes
Failures were detected on at least one updated target. Commits containing accuracy failures will often not be merged (unless a rationale is provided, such as false negatives due to regional differences). |
You’re right — sorry about that! I shouldn’t have included /user/ in the path. I’ve updated it to https://musescore.com/{} since https://musescore.com/arrangeme resolves correctly now. |
Great! Setting error type as status code seems to be giving a 403 response code for all usernames but changing it to message and setting error_msg to "<title>Page not found (404) | MuseScore.com</title>" seems to work. Not sure as to why this is happening. Any idea @ppfeister? |
Is the 404 page actually returning a 404 status code, or a 200 that says 404 to the user? If the actual status codes are in fact different, it's likely a request method issue. status_code defaults to HEAD whereas message defaults to GET. You can use status_code with GET however via the requestMethod attribute. (not at my desk, so the attribute names may be slightly off) |
When I load https://musescore.com/choldgraf on browser, it gives a status code of 404. But upon executing +++++++++++++++++++++
<<<<< END RESPONSE TEXT [*] Search completed with 0 results Looks like I need to use status_code with GET |
Thanks @akh7177 and @ppfeister. I confirmed locally that MuseScore returns a 403 for HEAD requests but works correctly with GET. I added "request_method": "GET" under "errorType": "status_code" and verified the following: arrangeme → Found (200) thisuserdoesnotexist999 → Not Found (404) This resolves the 403 issue on my end, though I haven’t seen other sites using a request_method field yet. |
Cool! Could you also modify that in this PR? |
Automatic validation of changes
|
Thanks! Just pushed the update with "request_method": "GET" for MuseScore. |
Added MuseScore support to data.json.
Validated JSON locally (python3 -m json.tool) — no syntax errors.
MuseScore pages return dynamic content, so username detection may currently return zero results, but the structure is correct and ready for future improvements.
This is a clean version of the earlier PR (#2600), created directly from master with no test HTML files or unintended PayPal changes.