Remove lat & long RegEx check

and let the Uber API handle it reliably

Author: agraebe

lib/Uber.js

@@ -203,18 +203,6 @@ Uber.prototype.get = function get(options, callback) {
     return this;
 };
 
-Uber.prototype.validateCoordinates = function validateCoordinates(lat, lon) {
-    if (!lat || !lon) {
-        return false;
-    }
-    // use regex to check for validaty of latitude and longitude
-    var location = lat + ', ' + lon;
-    // taken from: http://stackoverflow.com/questions/3518504/regular-expression-for-matching-latitude-longitude-coordinates
-    var locationReg = new RegExp(/[-+]?([1-8]?\d(\.\d+)?|90(\.0+)?),\s*[-+]?(180(\.0+)?|((1[0-7]\d)|([1-9]?\d))(\.\d+)?)/);
-
-    return locationReg.exec(location);
-};
-
 Uber.prototype.isNumeric = function isNumeric(input) {
     return (!input || isNaN(input)) ? false : true;
 };

lib/resources/Estimates.js

@@ -16,11 +16,11 @@ Estimates.prototype.getPriceForRoute = function getPriceForRoute(startLat,
         seats = 2;
     }
 
-    if (!this._uber.validateCoordinates(startLat, startLon)) {
+    if (!startLat || !startLon) {
         return callback(new Error('Invalid starting point latitude & longitude'));
     }
 
-    if (!this._uber.validateCoordinates(endLat, endLon)) {
+    if (!endLat || !endLon) {
         return callback(new Error('Invalid ending point latitude & longitude'));
     }
 
@@ -46,7 +46,7 @@ Estimates.prototype.getETAForLocation = function getETAForLocation(lat, lon, id,
         id = undefined;
     }
 
-    if (!lat || !lon || !this._uber.validateCoordinates(lat, lon)) {
+    if (!lat || !lon) {
         return callback(new Error('Invalid latitude & longitude'));
     }
 

lib/resources/Products.js

@@ -8,7 +8,7 @@ function Products(uber) {
 module.exports = Products;
 
 Products.prototype.getAllForLocation = function getAllForLocation(lat, lon, callback) {
-  if (!lat || !lon || !this._uber.validateCoordinates(lat, lon)) {
+  if (!lat || !lon) {
     return callback(new Error('Invalid latitude & longitude'));
   }
 

test/estimates.js

@@ -75,8 +75,15 @@ describe('Price', function() {
             });
     });
 
+    it('should return error if start point lat and lon are invalid', function(done) {
+        uber.estimates.getPriceForRoute(null, null, 3.1357, 101.6880, function(err, res) {
+            err.message.should.equal('Invalid starting point latitude & longitude');
+            done();
+        });
+    });
+
     it('should return error if end point lat and lon are invalid', function(done) {
-        uber.estimates.getPriceForRoute(3.1357, 101.6880, -91.1357, 181.6880, function(err, res) {
+        uber.estimates.getPriceForRoute(3.1357, 101.6880, null, null, function(err, res) {
             err.message.should.equal('Invalid ending point latitude & longitude');
             done();
         });