Skip to content

Commit 08cec87

Browse files
chenkinsdkocher
authored andcommitted
Cleanup hub synchronize test argument providers.
1 parent 7f1e2c2 commit 08cec87

File tree

3 files changed

+7
-14
lines changed

3 files changed

+7
-14
lines changed

hub/src/test/java/ch/iterate/hub/core/AbstractHubSynchronizeTest.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,13 +73,15 @@ public abstract class AbstractHubSynchronizeTest extends AbstractHubTest {
7373
private static final Logger log = LogManager.getLogger(AbstractHubSynchronizeTest.class.getName());
7474

7575
/**
76-
* Use to start unattended setup and then run tests with PUnattendedMinio.
76+
* Start with unattended setup (e.g. UnattendedMinio) and then run tests with corresponding attended setup (e.g. AttendedMinio) to save startup times at every test execution.
7777
*
7878
* @throws InterruptedException
7979
*/
8080
@Test
8181
@Disabled
82-
public void runForever() throws InterruptedException {
82+
public void startUnattendedSetupToUseAttended() throws InterruptedException {
83+
log.info("Unattended setup ready to be used in attended test runs.");
84+
// run forever
8385
Thread.sleep(924982347);
8486
}
8587

hub/src/test/java/ch/iterate/hub/core/HubSynchronizeTest.java

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,8 @@ private Stream<Arguments> arguments() {
3333

3434
@Nested
3535
@TestInstance(PER_CLASS)
36-
@Disabled("run standalone against already running hub started by runForever test.")
37-
public class PUnattendedMinio extends AbstractHubSynchronizeTest {
36+
@Disabled("run standalone against already running hub started by runForever test for unattended configuration.")
37+
public class AttendedMinio extends AbstractHubSynchronizeTest {
3838
private Stream<Arguments> arguments() {
3939
return Stream.of(minioStaticUnattendedLocalOnly, minioSTSUnattendedLocalOnly);
4040
}
@@ -50,16 +50,6 @@ private Stream<Arguments> arguments() {
5050
}
5151
}
5252

53-
54-
@Nested
55-
@TestInstance(PER_CLASS)
56-
@Disabled("run standalone against already running hub")
57-
public class AttendedMinio extends AbstractHubSynchronizeTest {
58-
private Stream<Arguments> arguments() {
59-
return Stream.of(minioStaticAttendedLocalOnly, minioSTSAttendedLocalOnly);
60-
}
61-
}
62-
6353
@Nested
6454
@TestInstance(PER_CLASS)
6555
@Disabled("run standalone against already running hub")

hub/src/test/java/ch/iterate/hub/testsetup/AbstractHubTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@
5353
public abstract class AbstractHubTest extends VaultTest {
5454

5555
static {
56+
// VaultTest is Junit 4 with @BeforeClass annotation, call statically in Jupiter setup.
5657
credentials();
5758
}
5859

0 commit comments

Comments
 (0)