Skip to content

Commit 4a64a93

Browse files
committed
Fix initialization.
1 parent 2463639 commit 4a64a93

File tree

2 files changed

+11
-109
lines changed

2 files changed

+11
-109
lines changed

hub/src/main/java/cloud/katta/protocols/hub/HubGrantAccessSchedulerService.java

Lines changed: 11 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@
1111
import ch.cyberduck.core.preferences.HostPreferences;
1212
import ch.cyberduck.core.shared.ThreadPoolSchedulerFeature;
1313

14+
import cloud.katta.client.api.StorageProfileResourceApi;
15+
1416
import org.apache.logging.log4j.LogManager;
1517
import org.apache.logging.log4j.Logger;
1618

@@ -25,7 +27,6 @@
2527
import cloud.katta.crypto.UserKeys;
2628
import cloud.katta.protocols.hub.exceptions.HubExceptionMappingService;
2729
import cloud.katta.workflows.DeviceKeysServiceImpl;
28-
import cloud.katta.workflows.GrantAccessService;
2930
import cloud.katta.workflows.GrantAccessServiceImpl;
3031
import cloud.katta.workflows.UserKeysServiceImpl;
3132
import cloud.katta.workflows.exceptions.AccessException;
@@ -36,40 +37,32 @@ public class HubGrantAccessSchedulerService extends ThreadPoolSchedulerFeature<H
3637

3738
private final HubSession session;
3839
private final HostPasswordStore keychain;
39-
private final VaultResourceApi vaults;
40-
private final UsersResourceApi users;
41-
private final DeviceResourceApi devices;
42-
private final GrantAccessService service;
4340

4441
public HubGrantAccessSchedulerService(final HubSession session, final HostPasswordStore keychain) {
45-
this(session, keychain, new VaultResourceApi(session.getClient()), new UsersResourceApi(session.getClient()), new DeviceResourceApi(session.getClient()), new GrantAccessServiceImpl(session));
46-
}
47-
48-
public HubGrantAccessSchedulerService(final HubSession session, final HostPasswordStore keychain, final VaultResourceApi vaults, final UsersResourceApi users, final DeviceResourceApi devices, final GrantAccessService service) {
4942
super(new HostPreferences(session.getHost()).getLong("hub.protocol.scheduler.period"));
5043
this.session = session;
5144
this.keychain = keychain;
52-
this.vaults = vaults;
53-
this.users = users;
54-
this.devices = devices;
55-
this.service = service;
5645
}
5746

5847
@Override
5948
public Host operate(final PasswordCallback callback) throws BackgroundException {
6049
log.info("Scheduler for {}", session.getHost());
6150
try {
62-
final UserKeys userKeys = new UserKeysServiceImpl(users, devices).getUserKeys(session.getHost(), session.getMe(),
51+
final UserKeys userKeys = new UserKeysServiceImpl(
52+
new UsersResourceApi(session.getClient()),
53+
new DeviceResourceApi(session.getClient())).getUserKeys(session.getHost(), session.getMe(),
6354
new DeviceKeysServiceImpl(keychain).getDeviceKeys(session.getHost()));
64-
65-
final List<VaultDto> accessibleVaults = vaults.apiVaultsAccessibleGet(Role.OWNER);
66-
55+
final List<VaultDto> accessibleVaults = new VaultResourceApi(session.getClient()).apiVaultsAccessibleGet(Role.OWNER);
6756
for(final VaultDto accessibleVault : accessibleVaults) {
6857
if(Boolean.TRUE.equals(accessibleVault.getArchived())) {
6958
log.debug("Skip archived vault {}", accessibleVault);
7059
continue;
7160
}
72-
service.grantAccessToUsersRequiringAccessGrant(accessibleVault.getId(), userKeys);
61+
new GrantAccessServiceImpl(
62+
new VaultResourceApi(session.getClient()),
63+
new StorageProfileResourceApi(session.getClient()),
64+
new UsersResourceApi(session.getClient())
65+
).grantAccessToUsersRequiringAccessGrant(accessibleVault.getId(), userKeys);
7366
}
7467
userKeys.destroy();
7568
}

hub/src/test/java/cloud/katta/protocols/hub/HubGrantAccessSchedulerServiceTest.java

Lines changed: 0 additions & 91 deletions
This file was deleted.

0 commit comments

Comments
 (0)