Javadoc and remove redundant method call.

Author: dkocher

hub/src/main/java/cloud/katta/crypto/uvf/UvfMetadataPayload.java

@@ -173,8 +173,13 @@ public JWKSet toJWKSet() {
             return new JWKSet(Arrays.asList(memberKey, recoveryKeyJWK));
         }
 
-        public String serializePublicRecoverykey() {
-            return new JWKSet(recoveryKeyJWK).toPublicJWKSet().toString();
+        /**
+         * Retrieve Recovery Key as JSON
+         *
+         * @return The JSON object string representation. Only public keys will be included
+         */
+        public String serializePublicRecoveryKey() {
+            return new JWKSet(recoveryKeyJWK).toString();
         }
 
         public UvfAccessTokenPayload toAccessToken() {

hub/src/main/java/cloud/katta/protocols/hub/HubUVFVault.java

@@ -111,7 +111,7 @@ public AbstractVault create(final Session<?> session, final String region, final
                     .archived(false)
                     .creationTime(DateTime.now())
                     .uvfMetadataFile(new String(VaultIdMetadataUVFProvider.cast(metadata).getMetadata(), StandardCharsets.US_ASCII))
-                    .uvfKeySet(VaultIdMetadataUVFProvider.cast(metadata).getJwks().serializePublicRecoverykey());
+                    .uvfKeySet(VaultIdMetadataUVFProvider.cast(metadata).getJwks().serializePublicRecoveryKey());
             // Create vault in Hub
             final VaultResourceApi vaultResourceApi = new VaultResourceApi(hub.getClient());
             log.debug("Create vault {}", vaultDto);

hub/src/test/java/cloud/katta/crypto/uvf/UvfMetadataPayloadTest.java

@@ -48,7 +48,7 @@ class UvfMetadataPayloadTest {
     void serializePublicRecoverykey() throws JOSEException {
         final UvfMetadataPayload.UniversalVaultFormatJWKS jwks = UvfMetadataPayload.createKeys();
         final ECKey recoveryKey = jwks.recoveryKey();
-        assertEquals(String.format("{\"keys\":[{\"kty\":\"EC\",\"crv\":\"P-384\",\"kid\":\"%s\",\"x\":\"%s\",\"y\":\"%s\",\"alg\":\"ECDH-ES+A256KW\"}]}", recoveryKey.getKeyID(), recoveryKey.getX(), recoveryKey.getY()), jwks.serializePublicRecoverykey());
+        assertEquals(String.format("{\"keys\":[{\"kty\":\"EC\",\"crv\":\"P-384\",\"kid\":\"%s\",\"x\":\"%s\",\"y\":\"%s\",\"alg\":\"ECDH-ES+A256KW\"}]}", recoveryKey.getKeyID(), recoveryKey.getX(), recoveryKey.getY()), jwks.serializePublicRecoveryKey());
     }
 
     @Test
@@ -64,7 +64,7 @@ void recoveryKeyToOwnerAccessTokenAndBack() throws JOSEException, ParseException
         final UvfMetadataPayload.UniversalVaultFormatJWKS jwks = UvfMetadataPayload.createKeys();
         final UvfAccessTokenPayload accessToken = jwks.toOwnerAccessToken();
 
-        final JWKSet recoveredJwks = JWKSet.parse(jwks.serializePublicRecoverykey());
+        final JWKSet recoveredJwks = JWKSet.parse(jwks.serializePublicRecoveryKey());
         assertEquals(1, recoveredJwks.getKeys().size());
         final ECKey publicRecoveryKey = (ECKey) recoveredJwks.getKeys().get(0);
         assertFalse(publicRecoveryKey.isPrivate());