Skip to content

Commit 84347a0

Browse files
committed
Extract field.
1 parent cd73a58 commit 84347a0

File tree

2 files changed

+15
-2
lines changed

2 files changed

+15
-2
lines changed

hub/src/main/java/ch/iterate/hub/protocols/hub/HubSession.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,11 @@
77
import ch.cyberduck.core.Credentials;
88
import ch.cyberduck.core.Host;
99
import ch.cyberduck.core.HostKeyCallback;
10+
import ch.cyberduck.core.HostPasswordStore;
1011
import ch.cyberduck.core.ListService;
1112
import ch.cyberduck.core.LocaleFactory;
1213
import ch.cyberduck.core.LoginCallback;
14+
import ch.cyberduck.core.PasswordStoreFactory;
1315
import ch.cyberduck.core.Profile;
1416
import ch.cyberduck.core.exception.BackgroundException;
1517
import ch.cyberduck.core.exception.ConnectionCanceledException;
@@ -61,14 +63,16 @@ public class HubSession extends HttpSession<HubApiClient> {
6163
*/
6264
public static final String HUB_UUID = "hub.uuid";
6365

66+
private final HostPasswordStore keychain = PasswordStoreFactory.get();
67+
6468
/**
6569
* Read storage configurations from API
6670
*/
6771
private final Scheduler<?> profiles = new HubStorageProfileSyncSchedulerService(this);
6872
/**
6973
* Read available vaults from API
7074
*/
71-
private final Scheduler<?> vaults = new HubStorageVaultSyncSchedulerService(this);
75+
private final Scheduler<?> vaults = new HubStorageVaultSyncSchedulerService(this, keychain);
7276
/**
7377
* Periodically grant vault access to users
7478
*/

hub/src/main/java/ch/iterate/hub/protocols/hub/HubStorageVaultSyncSchedulerService.java

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,14 +47,24 @@ public class HubStorageVaultSyncSchedulerService extends OneTimeSchedulerFeature
4747

4848
private final HubSession session;
4949
private final AbstractHostCollection bookmarks;
50+
private final HostPasswordStore keychain;
5051

5152
public HubStorageVaultSyncSchedulerService(final HubSession session) {
5253
this(session, BookmarkCollection.defaultCollection());
5354
}
5455

5556
public HubStorageVaultSyncSchedulerService(final HubSession session, final AbstractHostCollection bookmarks) {
57+
this(session, bookmarks, PasswordStoreFactory.get());
58+
}
59+
60+
public HubStorageVaultSyncSchedulerService(final HubSession session, final HostPasswordStore keychain) {
61+
this(session, BookmarkCollection.defaultCollection(), keychain);
62+
}
63+
64+
public HubStorageVaultSyncSchedulerService(final HubSession session, final AbstractHostCollection bookmarks, final HostPasswordStore keychain) {
5665
this.session = session;
5766
this.bookmarks = bookmarks;
67+
this.keychain = keychain;
5868
}
5969

6070
@Override
@@ -86,7 +96,6 @@ public List<VaultDto> operate(final PasswordCallback callback) throws Background
8696
final Host bookmark = toBookmark(session.getHost(), vaultId, vaultMetadata);
8797
if(bookmark.getCredentials().isPasswordAuthentication()) {
8898
log.warn("Save static access tokens for {} in keychain", vaultDto);
89-
final HostPasswordStore keychain = PasswordStoreFactory.get();
9099
keychain.save(bookmark);
91100
bookmark.getCredentials().reset();
92101
}

0 commit comments

Comments
 (0)