Merge pull request #190 from shiftcode/#189-remove-default-limit

#189 remove default limit

Author: michaelwittwer

README.md

@@ -43,8 +43,6 @@ personStore
 - [typescript-library-starter](https://github.com/alexjoverm/typescript-library-starter) - Starter project which helps creating a TypeScript library project
 - [vogels](https://github.com/ryanfitz/vogels) - To get an idea on how to build the fluent api
 - [typestore](http://densebrain.github.io/typestore/) - Inspiration on how to implement the model decorators
-- [BrowserStack](https://www.browserstack.com) - We use BrowserStack to verify everything works as expected
-![BrowserStack](https://github.com/shiftcode/dynamo-easy/browserstack-logo.png)
 
 ## Contributors
 Made with :heart: by [@michaelwittwer](https://github.com/michaelwittwer) and all these wonderful contributors ([emoji key](https://github.com/kentcdodds/all-contributors#emoji-key)):

browserstack-logo.png

@@ -18,6 +18,7 @@ import { DynamoDbWrapper } from '../../dynamo-db-wrapper'
 import { attribute } from '../../expression/logical-operator/attribute.function'
 import { ReadManyRequest } from '../read-many.request'
 import { QueryRequest } from './query.request'
+import * as DynamoDB from 'aws-sdk/clients/dynamodb'
 
 describe('query request', () => {
   let querySpy: jasmine.Spy
@@ -60,9 +61,7 @@ describe('query request', () => {
     })
 
     it('defaults should be defined', () => {
-      expect(request.params.TableName).toBe('complex_model')
-      expect(request.params.Limit).toBe(QueryRequest.DEFAULT_LIMIT)
-      expect(Object.keys(request.params).length).toBe(2)
+      expect(request.params).toEqual(<DynamoDB.QueryInput>{ TableName: 'complex_model' })
     })
 
     it('Limit', () => {

src/dynamo/request/query/query.request.spec.ts

@@ -35,9 +35,9 @@ describe('ReadManyRequest', () => {
     beforeEach(() => {
       request = new TestRequest(SimpleWithPartitionKeyModel)
     })
-    it('should set the default limit to params', () => {
-      expect(request.params).toBeDefined()
-      expect(request.params.Limit).toBe(ReadManyRequest.DEFAULT_LIMIT)
+
+    it('should set the default params', () => {
+      expect(request.params).toEqual({ TableName: getTableName(SimpleWithPartitionKeyModel) })
     })
   })
 
@@ -172,7 +172,7 @@ describe('ReadManyRequest', () => {
 
     it('execSingle should not alter request params', async () => {
       await request.execSingle()
-      expect(request.params.Limit).toBe(ReadManyRequest.DEFAULT_LIMIT)
+      expect(request.params.Limit).toBeUndefined()
     })
 
     it('execSingle empty response', async () => {

src/dynamo/request/read-many.request.spec.ts

@@ -32,7 +32,8 @@ export abstract class ReadManyRequest<T,
   O extends DynamoDB.QueryOutput | DynamoDB.ScanOutput,
   Z extends QueryResponse<T> | ScanResponse<T>,
   R extends QueryRequest<T> | ScanRequest<T>> extends StandardRequest<T, I, ReadManyRequest<T, I, O, Z, R>> {
-  static DEFAULT_LIMIT = 10
+
+  /** Infinite limit will remove the Limit param from request params when calling ReadManyRequest.limit(ReadManyRequest.INFINITE_LIMIT) */
   static INFINITE_LIMIT = -1
 
   protected secondaryIndex?: SecondaryIndex<T>
@@ -46,7 +47,6 @@ export abstract class ReadManyRequest<T,
 
   protected constructor(dynamoDBWrapper: DynamoDbWrapper, modelClazz: ModelConstructor<T>) {
     super(dynamoDBWrapper, modelClazz)
-    this.limit(ReadManyRequest.DEFAULT_LIMIT)
   }
 
   /**

src/dynamo/request/read-many.request.ts

@@ -28,10 +28,7 @@ describe('scan request', () => {
   })
 
   it('default params', () => {
-    const params: DynamoDB.ScanInput = request.params
-    expect(params.TableName).toBe('complex_model')
-    expect(params.Limit).toBe(ReadManyRequest.DEFAULT_LIMIT)
-    expect(Object.keys(params).length).toBe(2)
+    expect(request.params).toEqual(<DynamoDB.ScanInput>{ TableName: 'complex_model' })
   })
 
   it('execSingle', async () => {

src/dynamo/request/scan/scan.request.spec.ts

@@ -18,8 +18,8 @@ describe('StandardRequest', () => {
     }
   }
 
-  it('adds table name to params', () => {
+  it('creates default params with table name', () => {
     const msr = new MyStandardRequest(Organization)
-    expect(msr.params.TableName).toEqual(getTableName(Organization))
+    expect(msr.params).toEqual({ TableName: getTableName(Organization) })
   })
 })