test(requests): improve coverage

Author: michaelwittwer

README.md

@@ -1,6 +1,7 @@
 # Dynamo-Easy
 [![Travis](https://img.shields.io/travis/shiftcode/dynamo-easy.svg)](https://travis-ci.org/shiftcode/dynamo-easy)
 [![Coverage Status](https://img.shields.io/coveralls/jekyll/jekyll.svg)](https://coveralls.io/github/shiftcode/dynamo-easy?branch=master)
+[![Coverage Status](https://coveralls.io/repos/github/shiftcode/dynamo-easy/badge.svg?branch=master)](https://coveralls.io/github/shiftcode/dynamo-easy?branch=master)
 [![Dev Dependencies](https://img.shields.io/david/expressjs/express.svg)](https://david-dm.org/michaelwittwer/dynamo-easy?type=dev)
 [![Greenkeeper badge](https://badges.greenkeeper.io/alexjoverm/typescript-library-starter.svg)](https://greenkeeper.io/)
 [![styled with prettier](https://img.shields.io/badge/styled_with-prettier-ff69b4.svg)](https://github.com/prettier/prettier)

src/dynamo/request/get/get.request.spec.ts

@@ -1,14 +1,28 @@
+import { GetItemInput } from 'aws-sdk/clients/dynamodb'
 import { getTableName } from '../../../../test/helper/get-table-name.function'
 import { SimpleWithIdModel } from '../../../../test/models/simple-with-id.model'
 import { GetRequest } from './get.request'
 
 describe('get requst', () => {
+  let request: GetRequest<SimpleWithIdModel>
+
+  beforeEach(() => {
+    request = new GetRequest(null, SimpleWithIdModel, getTableName(SimpleWithIdModel), 'partitionKeyValue')
+  })
+
+  it('default params', () => {
+    const params: GetItemInput = request.params
+    expect(params.TableName).toBe('simple-with-id-models')
+    expect(params.Key).toEqual({ id: { S: 'partitionKeyValue' } })
+    expect(Object.keys(params).length).toBe(2)
+  })
+
   it('projection expression', () => {
-    const r = new GetRequest(null, SimpleWithIdModel, getTableName(SimpleWithIdModel), 'partitionKeyValue')
-    r.projectionExpression('name')
+    request.projectionExpression('name')
 
-    const params = r.params
+    const params = request.params
     expect(params.ProjectionExpression).toBe('#name')
     expect(params.ExpressionAttributeNames).toEqual({ '#name': 'name' })
+    expect(Object.keys(params).length).toBe(4)
   })
 })

src/dynamo/request/put/put.request.spec.ts

@@ -4,25 +4,37 @@ import { SimpleWithIdModel } from '../../../../test/models/simple-with-id.model'
 import { PutRequest } from './put.request'
 
 describe('put request', () => {
+  it('default params', () => {
+    const item: SimpleWithIdModel = { id: 'myId', age: 45 }
+    const request = new PutRequest(null, SimpleWithIdModel, getTableName(SimpleWithIdModel), item)
+    const params: PutItemInput = request.params
+
+    expect(params.TableName).toBe('simple-with-id-models')
+    expect(params.Item).toEqual({ id: { S: 'myId' }, age: { N: '45' } })
+    expect(Object.keys(params).length).toBe(2)
+  })
+
   describe('if exists condition', () => {
     it('simple', () => {
       const item: SimpleWithIdModel = { id: 'myId', age: 45 }
       const request = new PutRequest(null, SimpleWithIdModel, getTableName(SimpleWithIdModel), item)
       request.ifNotExists()
 
-      expect((<PutItemInput>request.params).ConditionExpression).toBe('attribute_not_exists (#id)')
-      expect((<PutItemInput>request.params).ExpressionAttributeNames).toEqual({ '#id': 'id' })
-      expect((<PutItemInput>request.params).ExpressionAttributeValues).toBeUndefined()
+      const params: PutItemInput = request.params
+      expect(params.ConditionExpression).toBe('attribute_not_exists (#id)')
+      expect(params.ExpressionAttributeNames).toEqual({ '#id': 'id' })
+      expect(params.ExpressionAttributeValues).toBeUndefined()
     })
 
     it('predicate', () => {
       const item: SimpleWithIdModel = { id: 'myId', age: 45 }
       const request = new PutRequest(null, SimpleWithIdModel, getTableName(SimpleWithIdModel), item)
       request.ifNotExists(25 + 20 === 40)
 
-      expect((<PutItemInput>request.params).ConditionExpression).toBeUndefined()
-      expect((<PutItemInput>request.params).ExpressionAttributeNames).toBeUndefined()
-      expect((<PutItemInput>request.params).ExpressionAttributeValues).toBeUndefined()
+      const params: PutItemInput = request.params
+      expect(params.ConditionExpression).toBeUndefined()
+      expect(params.ExpressionAttributeNames).toBeUndefined()
+      expect(params.ExpressionAttributeValues).toBeUndefined()
     })
   })
 })

src/dynamo/request/query/query.request.spec.ts

@@ -27,20 +27,11 @@ describe('query request', () => {
     it('defaults should be defined', () => {
       expect(request.params.TableName).toBe('complex_model')
       expect(request.params.Limit).toBe(QueryRequest.DEFAULT_LIMIT)
-      expect(request.params.IndexName).toBeUndefined()
-      expect(request.params.KeyConditions).toBeUndefined()
-      expect(request.params.KeyConditionExpression).toBeUndefined()
-      expect(request.params.ConditionalOperator).toBeUndefined()
-      expect(request.params.AttributesToGet).toBeUndefined()
-      expect(request.params.ConsistentRead).toBeUndefined()
-      expect(request.params.ExclusiveStartKey).toBeUndefined()
-      expect(request.params.ExpressionAttributeNames).toBeUndefined()
-      expect(request.params.ExpressionAttributeValues).toBeUndefined()
+      expect(Object.keys(request.params).length).toBe(2)
     })
 
     it('Limit', () => {
       request.limit(5)
-      expect(request.params).toBeDefined()
       expect(request.params.Limit).toBe(5)
     })
   })

src/dynamo/request/scan/scan.request.spec.ts

@@ -0,0 +1,28 @@
+import { ScanInput, ScanOutput } from 'aws-sdk/clients/dynamodb'
+import { Observable } from 'rxjs/Observable'
+import { getTableName } from '../../../../test/helper/get-table-name.function'
+import { ComplexModel } from '../../../../test/models/complex.model'
+import { Request } from '../request.model'
+import { ScanRequest } from './scan.request'
+
+class DynamoRxMock {
+  scan(): Observable<ScanOutput> {
+    return Observable.of({ Count: 10 })
+  }
+}
+
+describe('scan request', () => {
+  const dynamoRxMock: DynamoRxMock = new DynamoRxMock()
+  let scanRequest: ScanRequest<any>
+
+  beforeEach(() => {
+    scanRequest = new ScanRequest(<any>dynamoRxMock, ComplexModel, getTableName(ComplexModel))
+  })
+
+  it('default params', () => {
+    const params: ScanInput = scanRequest.params
+    expect(params.TableName).toBe('complex_model')
+    expect(params.Limit).toBe(Request.DEFAULT_LIMIT)
+    expect(Object.keys(params).length).toBe(2)
+  })
+})

yarn.lock

@@ -47,10 +47,6 @@
     lodash "^4.17.4"
     pify "^3.0.0"
 
-"@types/core-js@^0.9.43":
-  version "0.9.43"
-  resolved "https://registry.yarnpkg.com/@types/core-js/-/core-js-0.9.43.tgz#65d646c5e8c0cd1bdee37065799f9d3d48748253"
-
 "@types/debug@^0.0.30":
   version "0.0.30"
   resolved "https://registry.yarnpkg.com/@types/debug/-/debug-0.0.30.tgz#dc1e40f7af3b9c815013a7860e6252f6352a84df"