chore(tasks): classify of TODO and FIXME tasks

Author: michaelwittwer

src/dynamo/expression/condition-expression-builder.ts

@@ -228,7 +228,7 @@ function buildDefaultConditionExpression(
     let attribute: Attribute | null
     switch (operator) {
       case 'contains':
-        // TODO think about validation
+        // TODO LOW:VALIDATION think about concept
         // validateValueForContains(values[0], propertyMetadata)
         attribute = toDbOne(values[0], propertyMetadata)
         break
@@ -300,14 +300,14 @@ function validateValues(operator: ConditionOperator, values?: any[]) {
   }
 }
 
-// TODO should we support other types than String, Number, Binary (can we search a boolean set for example with boolean as string?)
+// TODO LOW:VALIDATION should we support other types than String, Number, Binary (can we search a boolean set for example with boolean as string?)
 // private static validateValueForContains(value: any, propertyMetadata?: PropertyMetadata<any>): { S: string } {
 //   let finalValue: { S: string }
 //   if (propertyMetadata && propertyMetadata.typeInfo) {
 //     switch (propertyMetadata.typeInfo.type) {
 //       case Array:
 //       case Set:
-//         // FIXME REVIEW the validation logic
+//         // TODO LOW:VALIDATION REVIEW the validation logic
 //         // const genericType = propertyMetadata.typeInfo.genericType
 //         // if ((!genericType && (typeof value === 'number' || typeof value === 'string' || typeof value === '')) || (
 //         //   genericType &&

src/dynamo/expression/type/update-expression-definition-chain.ts

@@ -5,7 +5,7 @@ import { UpdateExpressionDefinitionFunction } from './update-expression-definiti
  */
 export interface UpdateExpressionDefinitionChainTyped<T, K extends keyof T> {
   /* ----------------------------------------------------------------
-      SET operation TODO add support for ifNotExists
+      SET operation TODO add support for ifNotExists (#16)
    ---------------------------------------------------------------- */
   incrementBy: (value: number) => UpdateExpressionDefinitionFunction
   decrementBy: (value: number) => UpdateExpressionDefinitionFunction
@@ -67,7 +67,7 @@ export interface UpdateExpressionDefinitionChainTyped<T, K extends keyof T> {
  */
 export interface UpdateExpressionDefinitionChain {
   /* ----------------------------------------------------------------
-      SET operation TODO add support for ifNotExists
+      SET operation TODO add support for ifNotExists (#16)
    ---------------------------------------------------------------- */
   incrementBy: (value: number) => UpdateExpressionDefinitionFunction
   decrementBy: (value: number) => UpdateExpressionDefinitionFunction

src/dynamo/expression/update-expression-builder.ts

@@ -28,7 +28,7 @@ export function buildUpdateExpression(
   // metadata get rid of undefined values
   values = deepFilter(values, value => value !== undefined)
 
-  // TODO check if provided values are valid for given operation
+  // TODO LOW:VALIDATION check if provided values are valid for given operation
   // validateValues(operation, values)
 
   // load property metadata if model metadata was provided
@@ -106,9 +106,9 @@ function buildDefaultExpression(
       statement = values.map(pos => `${namePlaceholder}[${pos}]`).join(', ')
       break
     case 'add':
-      // TODO add validation to make sure expressionAttributeValue to be N(umber) or S(et)
+      // TODO LOW:VALIDATION add validation to make sure expressionAttributeValue to be N(umber) or S(et)
       statement = `${namePlaceholder} ${valuePlaceholder}`
-      // TODO won't work for numbers, is always gonna be mapped to a collection type
+      // TODO LOW:VALIDATION won't work for numbers, is always gonna be mapped to a collection type
       if ((values.length === 1 && Array.isArray(values[0])) || isSet(values[0])) {
         // dealing with arr | set as single argument
       } else {
@@ -117,7 +117,7 @@ function buildDefaultExpression(
       }
       break
     case 'removeFromSet':
-      // TODO add validation to make sure expressionAttributeValue to be S(et)
+      // TODO LOW:VALIDATION add validation to make sure expressionAttributeValue to be S(et)
       statement = `${namePlaceholder} ${valuePlaceholder}`
       if ((values.length === 1 && Array.isArray(values[0])) || isSet(values[0])) {
         // dealing with arr | set as single argument

src/dynamo/request/request.model.ts

@@ -74,7 +74,7 @@ export abstract class Request<T,
     return <any>this
   }
 
-  // TODO TYPING how can we improve the typing to define the accepted value for condition function (see
+  // TODO LOW:TYPING how can we improve the typing to define the accepted value for condition function (see
   // update2.function)
   whereAttribute(attributePath: keyof T): RequestConditionFunction<R> {
     return addCondition('FilterExpression', <string>attributePath, <any>this, this.metadata)