feat!: make wildcard params use simple regex fullmatch

Author: shiftinv

README.md

@@ -17,18 +17,18 @@ see [configuration](#configuration) below for more.
    `https://<filter_url>/1234/ABCDWXYZ` (note: no `/github`) in the GitHub webhook settings:\
    ![settings](./.github/assets/github-settings.png)
 3. Optionally add configuration parameters (see below) to the URL, e.g.
-   `?allowBranches=master,dev&hideTags=1`.
+   `?allowBranches=master|dev&hideTags=1`.
 4. ????
 5. Profit!
 
 ## Configuration
 
 Additional options can be configured per URL:
 
-- Only forward events from specific branches (`allowBranches`, simplified wildcard syntax)
-  - `abc*xyz` is equivalent to `/^(abc.*xyz)$/`
-  - `stuff,things` is equivalent to `/^(stuff|things)$/`
-  - `!oh*hi*there` is equivalent to `/^(oh.*hi.*there)$/` inverted
-- Ignore tag updates (`hideTags`)
-- Ignore burst PR review comments in a short timespan, only showing the first x comments per review
-  (`commentBurstLimit`)
+- `allowBranches`: Only forward events from specific branches
+  - This is case-sensitive and supports regex
+  - Only full matches are considered, i.e. no substrings; `abc.*xyz` is equivalent to
+    `/^(abc.*xyz)$/`
+- `hideTags`: Ignore tag updates
+- `commentBurstLimit`: Ignore burst PR review comments in a short timespan, only showing the first x
+  comments per review

src/util.ts

@@ -8,22 +8,12 @@ export function sleep(ms: number): Promise<void> {
     return new Promise((resolve) => setTimeout(resolve, ms));
 }
 
-function _escapeRegex(pattern: string): string {
-    return pattern.replace(/[.*+?^${}()|[\]\\]/g, "\\$&");
-}
-
 export function wildcardMatch(pattern: string, target: string): boolean {
     let invert = false;
     if (pattern[0] === "!") {
         invert = true;
         pattern = pattern.slice(1);
     }
-
-    // allow `*` wildcard specifier, translate to `.*` regex;
-    // escape everything else
-    pattern = pattern.split("*").map(_escapeRegex).join(".*");
-    // treat `,` as `|`
-    pattern = pattern.replaceAll(",", "|");
     // add anchors
     pattern = `^(${pattern})$`;