feat: add some debug logs for kv retries

Author: shiftinv

lib/filter.ts

@@ -52,7 +52,7 @@ export default async function filter(
             const cacheKey = `${reviewId}-${login}`;
 
             reqLog.debug(`filter: checking cache key ${cacheKey}`);
-            const curr = await getAndIncrementKV(cacheKey);
+            const curr = await getAndIncrementKV(cacheKey, reqLog);
             reqLog.debug(`filter: current value: ${curr}`);
 
             if (curr && curr >= config.commentBurstLimit) {

lib/kv.ts

@@ -1,9 +1,11 @@
+import type { RequestLog } from "./util.ts";
+
 const KEY_EXPIRY = 3; // seconds
 const MAX_RETRIES = 50;
 
 const kv = await Deno.openKv();
 
-export async function getAndIncrementKV(key: string): Promise<number> {
+export async function getAndIncrementKV(key: string, reqLog: RequestLog): Promise<number> {
     const kvKey = ["pr-comment", key];
 
     // keep retrying until atomic operation succeeds with same versionstamp
@@ -17,7 +19,10 @@ export async function getAndIncrementKV(key: string): Promise<number> {
             .check(res)
             .set(kvKey, value + 1, { expireIn: KEY_EXPIRY * 1000 })
             .commit();
-        if (setRes.ok) return value;
+        if (setRes.ok) {
+            reqLog.debug(`updated ${JSON.stringify(kvKey)} after ${i} retries`);
+            return value;
+        }
     }
 
     throw new Error(

lib/util.ts

@@ -56,3 +56,5 @@ export function requestLog(headers: Headers) {
         critical: proxyLog(log.critical),
     };
 }
+
+export type RequestLog = ReturnType<typeof requestLog>;