Skip to content

Commit 14a48af

Browse files
Merge pull request #100 from shiftstack/test_coverage_off
OSASINFRA-3918: posttriage: Remove check for Test coverage
2 parents 7c44aa9 + 3c38630 commit 14a48af

File tree

2 files changed

+0
-17
lines changed

2 files changed

+0
-17
lines changed

cmd/posttriage/checks.go

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -122,19 +122,3 @@ func TestCoverageFromIssue(issue jira.Issue) (testCoverage, error) {
122122
return testCoverageNone, fmt.Errorf("unknown test coverage value: %s", testCoverageMap["id"])
123123
}
124124
}
125-
126-
func testCoverageCheck(issue jira.Issue) (bool, string, error) {
127-
// If a bug has been closed as a non-bug, we shouldn't insist on test coverage.
128-
if isNotBug(issue) {
129-
return true, "", nil
130-
}
131-
132-
tc, err := TestCoverageFromIssue(issue)
133-
if err != nil {
134-
return false, "", fmt.Errorf("failed to parse Test coverage: %w", err)
135-
}
136-
if tc == testCoverageNone {
137-
return false, "the Test coverage assessment is missing", nil
138-
}
139-
return true, "", nil
140-
}

cmd/posttriage/main.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ func main() {
2727
triageChecks := [...]triageCheck{
2828
priorityCheck,
2929
releaseBlockerCheck,
30-
testCoverageCheck,
3130
}
3231

3332
var (

0 commit comments

Comments
 (0)