Skip to content

Commit f09c5d3

Browse files
authored
add member name as key when comparing pool members (kubernetes#2011)
1 parent 8468706 commit f09c5d3

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

pkg/openstack/loadbalancer.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1249,7 +1249,7 @@ func (lbaas *LbaasV2) ensureOctaviaPool(lbID string, name string, listener *list
12491249
klog.Errorf("failed to get members in the pool %s: %v", pool.ID, err)
12501250
}
12511251
for _, m := range poolMembers {
1252-
curMembers.Insert(fmt.Sprintf("%s-%d-%d", m.Address, m.ProtocolPort, m.MonitorPort))
1252+
curMembers.Insert(fmt.Sprintf("%s-%s-%d-%d", m.Name, m.Address, m.ProtocolPort, m.MonitorPort))
12531253
}
12541254

12551255
members, newMembers, err := lbaas.buildBatchUpdateMemberOpts(port, nodes, svcConf)
@@ -1328,7 +1328,7 @@ func (lbaas *LbaasV2) buildBatchUpdateMemberOpts(port corev1.ServicePort, nodes
13281328
member.MonitorPort = &svcConf.healthCheckNodePort
13291329
}
13301330
members = append(members, member)
1331-
newMembers.Insert(fmt.Sprintf("%s-%d-%d", addr, member.ProtocolPort, svcConf.healthCheckNodePort))
1331+
newMembers.Insert(fmt.Sprintf("%s-%s-%d-%d", node.Name, addr, member.ProtocolPort, svcConf.healthCheckNodePort))
13321332
}
13331333
return members, newMembers, nil
13341334
}

0 commit comments

Comments
 (0)