Skip to content

Commit b50d2d2

Browse files
committed
ci: improve e2e tests
1 parent e2a6624 commit b50d2d2

File tree

1 file changed

+18
-14
lines changed

1 file changed

+18
-14
lines changed

.github/workflows/reusable-test.yml

Lines changed: 18 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -237,7 +237,7 @@ jobs:
237237
run-e2e-tests:
238238
if: ${{ inputs.use-matrix == true }}
239239
runs-on: ubuntu-latest
240-
needs: build-modern-node
240+
# needs: build-modern-node
241241
# Use Playwright container for E2E tests, which has all dependencies and all browsers installed
242242
# container: mcr.microsoft.com/playwright:v1.52.0-jammy
243243
# env:
@@ -253,29 +253,33 @@ jobs:
253253
uses: actions/setup-node@v4
254254
with:
255255
node-version: ${{ vars.DEFAULT_NODE_VERSION }}
256+
cache: 'npm'
256257

257258
- name: Install Playwright dependencies
258259
run: npx playwright install-deps webkit
259260

260-
- name: Restore modern node_modules cache
261-
uses: actions/cache@v4
262-
with:
263-
path: |
264-
node_modules
265-
key: ${{ runner.os }}-modern-node-modules-${{ hashFiles('**/package-lock.json') }}
261+
# - name: Restore modern node_modules cache
262+
# uses: actions/cache@v4
263+
# with:
264+
# path: |
265+
# node_modules
266+
# key: ${{ runner.os }}-modern-node-modules-${{ hashFiles('**/package-lock.json') }}
267+
268+
- name: Install dependencies
269+
run: npm ci
266270

267271
- name: Install playwright browsers
268272
run: npx playwright install
269273

270-
- name: Download build output from artifacts
271-
id: download_build_output
272-
uses: actions/download-artifact@v4
273-
continue-on-error: true
274-
with:
275-
name: ${{ runner.os }}-modern-build-output-${{ github.sha }}
274+
# - name: Download build output from artifacts
275+
# id: download_build_output
276+
# uses: actions/download-artifact@v4
277+
# continue-on-error: true
278+
# with:
279+
# name: ${{ runner.os }}-modern-build-output-${{ github.sha }}
276280

277281
- name: Build package
278-
if: steps.download_build_output.outcome != 'success'
282+
# if: steps.download_build_output.outcome != 'success'
279283
run: npm run build
280284

281285
- name: Run e2e tests

0 commit comments

Comments
 (0)