Skip to content

Commit f86083d

Browse files
committed
ci: run node.js esm tests on commit
1 parent 1fd2451 commit f86083d

File tree

4 files changed

+4
-34
lines changed

4 files changed

+4
-34
lines changed

.github/workflows/reusable-test.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ jobs:
169169
needs: build-for-node-modern
170170
strategy:
171171
matrix:
172-
node-version: [16.x, 17.x, 18.x, 19.x, 20.x, 21.x, 22.x, 23.x]
172+
node-version: [16.x, 17.x, 18.x, 19.x, 20.x, 21.x, 22.x, 23.x, 24.x]
173173
steps:
174174
- uses: actions/checkout@v4
175175

@@ -245,7 +245,7 @@ jobs:
245245
needs: build-for-node-modern
246246
strategy:
247247
matrix:
248-
node-version: [16.x, 17.x, 18.x, 19.x, 20.x, 21.x, 22.x, 23.x]
248+
node-version: [16.x, 17.x, 18.x, 19.x, 20.x, 21.x, 22.x, 23.x, 24.x]
249249
steps:
250250
- uses: actions/checkout@v4
251251

@@ -280,7 +280,7 @@ jobs:
280280
run-e2e:
281281
if: ${{ inputs.use-matrix == true }}
282282
runs-on: ubuntu-latest
283-
# needs: build-modern-node
283+
needs: [build-for-node-modern, node-modules-cache]
284284
steps:
285285
- uses: actions/checkout@v4
286286

@@ -316,7 +316,7 @@ jobs:
316316
name: ${{ runner.os }}-modern-build-output-${{ github.sha }}
317317

318318
- name: Build package
319-
# if: steps.download_build_output.outcome != 'success'
319+
if: steps.download_build_output.outcome != 'success'
320320
run: npm run build
321321

322322
- name: Run e2e tests

jest-esm-config.json

Lines changed: 0 additions & 25 deletions
This file was deleted.

jest-esm-legacy.config.js

Lines changed: 0 additions & 3 deletions
This file was deleted.

package.json

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -109,14 +109,12 @@
109109
"task:jest": "jest --coverage",
110110
"task:jest-cjs": "jest --coverage -c jest-cjs.config.js",
111111
"task:jest-esm": "jest --coverage -c jest-esm.config.js",
112-
"task:jest-esm-legacy": "jest --coverage -c jest-esm-legacy.config.js",
113112
"task:run-e2e": "playwright test",
114113
"task:run-e2e-debug": "playwright test --debug",
115114
"task:run-e2e-ui": "playwright test --ui",
116115
"test": "npm run task:jest",
117116
"test-node-cjs": "run-s ts2lib task:jest-cjs",
118117
"test-node-esm": "run-s build:tses task:jest-esm",
119-
"test-node-esm-legacy": "run-s build:tses task:jest-esm-legacy",
120118
"ts2es": "tsc -p tsconfig.es.json",
121119
"ts2lib": "tsc -p tsconfig.lib.json"
122120
},

0 commit comments

Comments
 (0)