feat: tmp

Author: shijistar

enum-plus-v3.md

@@ -52,6 +52,10 @@
 - `enum.valuesEnum` method is removed, use `enum.toValueMap` instead.
 - The behavior of `enum.values` is changed. Use `enum.items` for the old behavior.
 
+## Misc
+
+- The warning message for trying to modify enum items has been removed. First, in order to avoid circular references within enum items (which would affect serialization), we removed the internal `proxy` and used `getter/setter` instead. However, this brought about another problem: when printing enum items in the browser console or node.js, the `key`, `value`, and `label` cannot display their values, but show `[Getter/Setter]` instead. This somewhat affects the debugging experience. Sorry @yyz945947732, you introduced this feature, which is very good, but after weighing the pros and cons, we still had to remove this feature.
+
 ## Bug Fixes
 
 - Fix the issue where sourcemap files under the `lib` directory could not be parsed.

src/enum-collection.ts

@@ -42,7 +42,7 @@ export class EnumCollectionClass<
   implements
     Omit<IEnumItems<T, K, V>, typeof IS_ENUM_ITEMS | typeof ITEMS | typeof KEYS | typeof VALUES | 'labels' | 'meta'>
 {
-  private __options__: EnumItemOptions | undefined;
+  private readonly __options__: EnumItemOptions | undefined;
   // used for e2e serialization
   private readonly __items__!: EnumItemsArray<T, K, V>;
 

src/enum-items.ts

@@ -114,18 +114,18 @@ export class EnumItemsArray<
     this[VALUES] = values;
     Object.freeze(values);
 
-    this._runtimeError = undefined!;
     // Generate labels array
     Object.defineProperty(this, 'labels', {
-      enumerable: true,
-      configurable: false,
       get: function (this: EnumItemsArray<T, K, V>) {
         // Cannot save to static array because labels may be localized contents
         // Should not use `items` in the closure because the getter function cannot be fully serialized
-        return this.map((item) => item.label);
+        return Array.from(this).map((item) => item.label);
       },
+      enumerable: true,
+      configurable: false,
     });
 
+    this._runtimeError = undefined!;
     Object.defineProperty(this, '_runtimeError', {
       value: function (this: EnumItemsArray<T, K, V>, name: string) {
         return `The ${name} property of the enumeration is only allowed to be used to declare the ts type, and cannot be accessed at runtime! Please use the typeof operator in the ts type, for example: typeof Week.${name}`;
@@ -269,9 +269,9 @@ export class EnumItemsArray<
       >[] {
     const { valueField = 'value' as FOV, labelField = 'label' as FOL } = config ?? {};
     if (valueField === 'value' && labelField === 'label') {
-      return this;
+      return Array.from(this);
     } else {
-      return this.map((item) => {
+      return Array.from(this).map((item) => {
         const valueFieldName = typeof valueField === 'function' ? valueField(item) : (valueField as string);
         const labelFieldName = typeof labelField === 'function' ? labelField(item) : (labelField as string);
         const listItem = {
@@ -310,11 +310,11 @@ export class EnumItemsArray<
   }
 
   toMenu(): MenuItemOption<V>[] {
-    return this.map(({ value, label }) => ({ key: value, label }));
+    return Array.from(this).map(({ value, label }) => ({ key: value, label }));
   }
 
   toFilter(): ColumnFilterItem<V>[] {
-    return this.map(({ value, label }) => ({ text: label, value }));
+    return Array.from(this).map(({ value, label }) => ({ text: label, value }));
   }
 
   /** Stub method, only for typing usages, not for runtime calling */

test/test-suites/enum-collection.ts

@@ -171,6 +171,7 @@ const testEnumCollection = (engine: TestEngineBase) => {
         return { week };
       },
       ({ week }) => {
+        // console.log(week.__items__);
         engine.expect((0 as unknown) instanceof week).toBeTruthy();
         engine.expect(('Sunday' as unknown) instanceof week).toBeTruthy();
         engine.expect((6 as unknown) instanceof week).toBeTruthy();